review changes

zeldaret · Apr 22, 2024 · f7b427f · f7b427f
1 parent 5f7c888
commit f7b427f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/Game/gamePlayReport.cpp b/src/Game/gamePlayReport.cpp
@@ -9,8 +9,7 @@
 
 namespace uking {
 
-unsigned int getQuestId(const sead::SafeString& quest_name);
-int positionFunc(const sead::Vector2i& pos);
+int convertPositionToInt(const sead::Vector2i& pos);
 
 void reportKorok(const sead::Vector3f& position) {
     ksys::ProductReporter::getSomeBool();
@@ -239,19 +238,19 @@ unsigned int getQuestId(const sead::SafeString& quest_name) {
     return 0;
 }
 
-void reportGetItem(const sead::Vector3f& pos, const sead::SafeString* targetActorName) {
+void reportGetItem(const sead::Vector3f& pos, const sead::SafeString& item_name) {
     ksys::ProductReporter::getSomeBool();
     PlayReport report(sead::SafeString("getitem"), 7,
                       ksys::PlayReportMgr::instance()->getReporter()->getHeap());
     report.addMapType();
 
-    int name = (int)sead::HashCRC32::calcStringHash(*targetActorName);
+    auto name = static_cast<int>(sead::HashCRC32::calcStringHash(item_name));
 
     ksys::ProductReporter::getSomeBool();
 
     report.add(sead::SafeString("name"), name);
 
-    int position = positionFunc({int(pos.x), int(pos.y)});
+    int position = convertPositionToInt({int(pos.x), int(pos.y)});
 
     report.add(sead::SafeString("Position"), position);
     report.addPlayTimes();

diff --git a/src/Game/gamePlayReport.h b/src/Game/gamePlayReport.h
@@ -12,7 +12,7 @@ namespace uking {
 void reportKorok(const sead::Vector3f& position);
 void reportDungeon(const sead::SafeString& name, const sead::SafeString& event);
 void reportQuestStep(const ksys::qst::Quest* quest, int step_index);
-void reportGetItem(const sead::Vector3f& pos, const sead::SafeString* targetActorName);
+void reportGetItem(const sead::Vector3f& pos, const sead::SafeString& item_name);
 
 // TODO: More functions