Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bool everywhere in mcard #181

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Use bool everywhere in mcard #181

merged 1 commit into from
Sep 19, 2024

Conversation

cadmic
Copy link
Collaborator

@cadmic cadmic commented Sep 19, 2024

Part 1 of mcard cleanups. For things named toggle I'm not sure whether to use true/false or 0/1 (like an enum, I guess), since they do toggle == 1 a lot. Then again, the also do someFunctionReturningABool() == true a lot too so maybe that's just the style in this file.

Copy link
Collaborator

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused by mCard.file.game.writtenBlocks but it must be an array to know which blocks are written or something like that so it makes sense it's a bool too

@cadmic cadmic merged commit 7859f95 into zeldaret:main Sep 19, 2024
2 checks passed
@cadmic cadmic deleted the mcard-bool branch September 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants