Match and link cpu.c #199
Merged
Match and link cpu.c #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yanis002
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created _cpuGCN.c and _cpuDecodePPC.c, based on debug info and oot-vc function order, since apparently including other source files changes function ordering but not data ordering. I also fixed a few things that weren't actually matching.
Some things I'm unsure about:
treePrint, so I created a dummy function for these, but I forgot if there's another way to do itcpuCountTLBseems like it should return a boolean but I can't get that to match while using it incpuExecuteOpcode. Maybe there's a different inline here?