Struct Returns #1574
Merged
Struct Returns #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensldm
approved these changes
Nov 6, 2023
mzxrules
reviewed
Nov 6, 2023
AngheloAlf
approved these changes
Nov 6, 2023
Dragorn421
reviewed
Nov 7, 2023
src/code/z_camera.c
Outdated
| @@ -464,10 +458,10 @@ Vec3s* Camera_GetBgCamFuncData(Camera* camera) { | |||
| */ | |||
| s32 Camera_GetBgCamIndex(Camera* camera, s32* bgId, CollisionPoly* poly) { | |||
| s32 bgCamIndex; | |||
| PosRot playerPosRot; | |||
| UNUSED PosRot playerPosRot; | |||
There was a problem hiding this comment.
We don't use unused in oot so far #1321
There was a problem hiding this comment.
It's worth noting that the are already 3 uses of UNUSED in z_camera.c, and that a lot of warnings are added without the UNUSED. But I'll leave it to that PR to sort out, so I've removed them
|
pr looks good to me after a couple pending comments are addressed |
Dragorn421
reviewed
Nov 19, 2023
cadmic
added a commit
to cadmic/oot-setups
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the rare instances where changing the number of arguments retains the same codegen. There's a pattern where a struct-returning functions takes an out-pointer as first arg and also return that pointer. Both seem to match but it seems likely that it was the first given the redundancy of having both an arg and a return give a pointer for a destination. See zeldaret/mm#1466 and the conversation here https://discord.com/channels/688807550715560050/688851997352263820/1170905743566835836
This also revealed some more unused variables, which has
UNUSEDadded to them