-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colliders: elemType -> elemMaterial #2189
Conversation
/* 5 */ ELEM_MATERIAL_UNK5, | ||
/* 6 */ ELEM_MATERIAL_UNK6, | ||
/* 7 */ ELEM_MATERIAL_UNK7 | ||
} ElementMaterial; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed, the structs above this use ColliderElementXXXXXX
instead of simply ElementXXXX
like this one. should it be consistent? (not that it matters much, this enum name is never referenced afaict 😁 )
To me, it just looks like |
that is what dragorn said, with the added detail that it prevents a hit sfx from playing |
what he wrote does not make it clear that the detected collision with a collider is being thrown away unconditionally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont think material particularly works for the arrow/hookshot thing, but am willing to go with it for now
Split from #1925
Rename
ColliderElement.elemType
/ELEMTYPE_
->ColliderElement.elemMaterial
/ELEM_MATERIAL_
The
elemMaterial
is primarily used to determine the sfx made when struck by the player (0:NA_SE_IT_SWORD_STRIKE
, 1:NA_SE_IT_SWORD_STRIKE_HARD
, others: no sound) (inCollisionCheck_SwordHitAudio
)Additionally
ELEM_MATERIAL_UNK4
prevents some behavior from interactions with hookshot and arrows.ACELEM_HOOKABLE
is thatELEM_MATERIAL_UNK4
prevents playing the soundNA_SE_IT_ARROW_STICK_CRE
and the hookshot keeps going (I think)ACTOR_FLAG_14
("ACTOR_FLAG_ARROW_CAN_CARRY
") is thatELEM_MATERIAL_UNK4
prevents playing the soundNA_SE_IT_ARROW_STICK_CRE
and the arrow keeps going (I think)