Document Save.cutsceneIndex and adjacent data / code
#2286
+275
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it doesn't clutter previous commit. still, allowing `clangd LSP` to run format-on-save yields inconsistent results for me with the project's tooling, especially for header files
mzxrules
reviewed
Nov 5, 2024
Co-authored-by: mzxrules <[email protected]>
and some additional observations reverified with > `check_format.py ...` > `make ...` additionally: - current clang-format lacks a rule for trailing commas - compiler says about them `cfe: Warning 624`
zeldaret#2286 (comment) reverified with > `check_format.py ...` > `make ...`
https://jenkins.deco.mp/job/OOT/job/PR-2286/4/console hmm, i do need this automation locally to
and add a comment chunk from zeldaret#2286 (comment)
it gets assigned to the `nextCutsceneIndex`, so `CS_INDEX_NONE` name was misleading
the purpose of `CS_INDEX_BARRIER` is not quite clear still
`ntsc-1.2` refused to comply though
probably size of enum entries doesn't match well? originally these were just numbers. besides, not like it's a real enumeration from zero to a value or some bit flags
cadmic
reviewed
Nov 27, 2024
|
(unresolved as needed) |
Feacur
force-pushed
the
doc/cutscene_index
branch
from
c91e8c0 to
6efea0a
Compare
mzxrules
reviewed
Dec 1, 2024
zeldaret#2286 (comment) essentially reverts 106cb10, except for 2 generic `z_scene.c` lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while studying the game logic flow, i saw there's a pattern between
Save.entranceIndexSave.cutsceneIndexSaveContext.sceneLayerbut values weren't yet described. so, it's time to cleanup my notes and shape them in a proper PR.
(UPD: not anymore) it's a WIP, but i'll start with a draft for visibilityP.S.:
the closest thing i see here is #1300, but
SaveContext.sceneLayer