Restructure event flags in z64save.h (3/?): Cursed Family Rewards #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadmic
approved these changes
Dec 27, 2024
fig02
reviewed
Dec 28, 2024
| @@ -388,6 +383,9 @@ Gfx* EnSth_AllocColorDList(GraphicsContext* play, u8 envR, u8 envG, u8 envB, u8 | |||
| } | |||
|
|
|||
| void EnSth_Draw(Actor* thisx, PlayState* play) { | |||
| static Color_RGB8 sTunicColors[6] = { | |||
There was a problem hiding this comment.
not related to your changes of course, but is tunic really the best word here? makes it sound like link lol
arent they just shirts?
There was a problem hiding this comment.
Wikipedia defines tunic as
a garment for the torso, usually simple in style, reaching from the shoulders to a length somewhere between the hips and the ankles.
I don't think the little bit below the belt makes it a tunic
fig02
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions made in this pr are licensed under CC0
Continuation of #2303
Also fixed a few minor things.