Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress categories support #677

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

encounter
Copy link
Collaborator

Was using tww as a test-bed for encounter/dtk-template#33

I can revert the changes to the libraries and set them on the individual Objects instead (e.g. Object("foo", progress_category="game")), so let me know.

CI now uses the built-in objdiff report functionality in dtk-template. I assume your website script doesn't care about the report artifact name, but if it does, I can revert that change. (My upcoming progress service does match by artifact name)

@LagoLunatic
Copy link
Collaborator

I assume your website script doesn't care about the report artifact name, but if it does, I can revert that change. (My upcoming progress service does match by artifact name)

It does, if you scroll down in build.yml it matches on the name being GZLE01-report-${{ github.sha }}. I included the hash because I thought download-artifact needs you to specify exactly which one to download, but I think I might have misunderstood the documentation?

You can probably remove the -${{ github.sha }} from there too and we can see if it still works.

@encounter
Copy link
Collaborator Author

Don't know how I missed that! Updated. upload/download-artifact are scoped to the current workflow run, so no sha is needed.

@LagoLunatic LagoLunatic merged commit da7a1c4 into zeldaret:main Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants