Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Add docs for extension config parameter for zend view renderer #664

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xerkus
Copy link
Member

@Xerkus Xerkus commented Jun 4, 2019

Provide a narrative description of what you are trying to accomplish:

2.2.0 release of zendframework/zend-expressive-zendviewrenderer adds support for extension parameter for default suffix to be used by zend-view resolver, in line with other template renderers.

  • Is this related to documentation?
    Add documentation entry for extension config parameter.

@@ -505,6 +506,8 @@ It consumes the following `config` structure:
]
```

- `extension` parameter available since `zendframework/zend-expressive-zendviewrenderer` 2.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set the version at the beginning?

Since 2.2.0: extension parameter...

This would be consistent with most version informations in the documentation. Thanks!

Copy link
Member Author

@Xerkus Xerkus Jun 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be confusing since this is zend-expressive documentation and release mentioned is from different package?

Suggested change
- `extension` parameter available since `zendframework/zend-expressive-zendviewrenderer` 2.2.0
- Since ZendViewRenderer 2.2.0: `extension` parameter is used to configure default suffix in NamespacedPathStackResolver

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue open for splitting the documentation: #594

@weierophinney
Copy link
Member

This repository has been closed and moved to mezzio/mezzio; a new issue has been opened at mezzio/mezzio#2.

@weierophinney
Copy link
Member

This repository has been moved to mezzio/mezzio. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone mezzio/mezzio to another directory.
  • Copy the files from the second bullet point to the clone of mezzio/mezzio.
  • In your clone of mezzio/mezzio, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants