Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: macos-latest CIs both failing #4701

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

fanquake
Copy link
Contributor

@fanquake fanquake commented Jul 8, 2024

Solution: Install libtool. This seems to be the issue, given the CI output of a recent run, i.e:

 configure.ac:1023: the top level
configure.ac:80: error: possibly undefined macro: AC_LIBTOOL_WIN32_DLL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:81: error: possibly undefined macro: AC_PROG_LIBTOOL
configure:7350: error: possibly undefined macro: AC_DISABLE_STATIC
configure:7354: error: possibly undefined macro: AC_ENABLE_STATIC
autoreconf: error: /opt/homebrew/Cellar/autoconf/2.72/bin/autoconf failed with exit status: 1
autogen.sh: error: autoreconf exited with status 1
+ exit 1

For example, a CI run from the recent opened #4699: https://github.com/zeromq/libzmq/actions/runs/9841129190/job/27167025854?pr=4699#step:12:200.

Solution: Install `libtool`. This seems to be the issue, given the CI
output of a recent run, i.e:
```bash
 configure.ac:1023: the top level
configure.ac:80: error: possibly undefined macro: AC_LIBTOOL_WIN32_DLL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:81: error: possibly undefined macro: AC_PROG_LIBTOOL
configure:7350: error: possibly undefined macro: AC_DISABLE_STATIC
configure:7354: error: possibly undefined macro: AC_ENABLE_STATIC
autoreconf: error: /opt/homebrew/Cellar/autoconf/2.72/bin/autoconf failed with exit status: 1
autogen.sh: error: autoreconf exited with status 1
+ exit 1
```
https://github.com/zeromq/libzmq/actions/runs/9841129190/job/27167025854?pr=4699#step:12:200
@fanquake fanquake force-pushed the macos_ci_missing_libtool branch from f3253b0 to 84d8eff Compare July 8, 2024 14:42
@fanquake fanquake changed the title Porblem: macos-latest CIs both failing Problem: macos-latest CIs both failing Jul 8, 2024
@fanquake
Copy link
Contributor Author

fanquake commented Jul 8, 2024

Now that the CIs are running, looks like there's at least one other failure. i.e https://github.com/zeromq/libzmq/actions/runs/9841741306/job/27169057898?pr=4701#step:12:1374:

 ../../src/curve_mechanism_base.hpp:9:10: fatal error: 'sodium.h' file not found
#include "sodium.h"
         ^~~~~~~~~~
ld: warning: -bind_at_load is deprecated on macOS
ld: warning: search path '/Users/runner/work/libzmq/libzmq/libzmq/tmp/lib' not found
ld: warning: -bind_at_load is deprecated on macOS
ld: warning: search path '/Users/runner/work/libzmq/libzmq/libzmq/tmp/lib' not found
1 error generated.

@bluca bluca merged commit de290e9 into zeromq:master Jul 8, 2024
53 of 61 checks passed
@fanquake fanquake deleted the macos_ci_missing_libtool branch July 8, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants