Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite Cython backend using Cython 3 pure Python mode #1884

Merged
merged 29 commits into from
Oct 11, 2023
Merged

rewrite Cython backend using Cython 3 pure Python mode #1884

merged 29 commits into from
Oct 11, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 10, 2023 •
edited
Loading

  • pure Python so linters, formatters, etc. work
  • requires Cython 3 for pure Python with cimports
  • single extension file for simpler compilation/deployment (e.g. especially with statically linked libzmq) and more efficient imports
  • take this opportunity to purge tiny remaining LGPL bits of the Cython backend with a new implementation, so pyzmq is now just BSD (closes RELICENSE pyzmq core #1039)

closes #1040

@minrk minrk marked this pull request as draft July 10, 2023 06:28
minrk added 17 commits July 22, 2023 14:17
@minrk
begin rewriting Cython backend using Cython 3.0 pure Python
fb350e9 
this rewrite will be BSD licensed
@minrk
nicer reprs of Frames
ffa852b 
show contents of short messages, length of long ones
@minrk
use top-level import for Cython backend
96b57b3
@minrk
implement error functions in new Cython backend
d96ea6c
@minrk
add context to new backend
7809795
@minrk
tighter lint except on tests/examples
ae3e934
@minrk
# This is a combination of 2 commits.
62a27ab 
# This is the 1st commit message:

add socket to new cython backend

# The commit message zeromq#2 will be skipped:

# checkpoint
@minrk
implement devices, polling in new cython backend
886a7ac
@minrk
add monitoredqueue to the backend
7cddf49 
now down to a single Extension for Cython
@minrk
Remove the old LGPL Cython backend
f54910d
@minrk
remove LGPL examples
f9bcdfd
@minrk
pyzmq no longer ships an LGPL core, it is BSD-only
2f461c5
@minrk
cleanup setup.py now with single Cython extension
3359c12
@minrk
update RELICENSE as complete
79dffd5
@minrk
Bump to 26.0.0.dev
4c0b903
@minrk
add monitored_queue to backend imports
7e57854 
but keep it out of the public API, so it stays out of top-level zmq namespace
@minrk
update cython backend path in test_sdist
e75d1bf
@minrk minrk mentioned this pull request Aug 29, 2023
Closed
@minrk
unregister wrapped sockets from event loop when they're done
797db9e 
avoids low-level sockets being closed before unregistering with loop (mainly an issue on Windows)
@minrk minrk marked this pull request as ready for review October 11, 2023 09:06
@minrk minrk merged commit 96ad4c5 into zeromq:main Oct 11, 2023
26 checks passed
@minrk minrk deleted the single-cython branch October 11, 2023 09:14
@minrk minrk mentioned this pull request Oct 11, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RELICENSE pyzmq core
1 participant
@minrk