-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP meson #1922
Closed
Closed
WIP meson #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libzmq no longer supports binaries for Windows, and has removed support for tweetnacl. This may mean that Windows wheels will lose CURVE.
Cython works with existing libzmq
libzmq's libsodium & cmake build steps are here and amount to:
it should be a relatively small task to switch those builds to static and run these commands as custom targets, at least for someone who understands more about meson and Windows builds than I do. |
need to figure out how to prevent ExternalProject from running configure during sdist:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try switching build system to meson, which lets us bundle 'true' builds of libzmq/libsodium.
builds on #1903, because that's why we need it, since libsodium becomes a dependency of bundled libzmq due to the removal of libzmq's tweetnacl.
So far, the simple Cython + CPython on linux/mac is working
TODO:
meson discussion