Add support for keyboard via a @useFocus
argument
#30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
@useFocus
argument to the tooltip component (off by default) to allow showing the tooltip when a user focuses the tooltipper instead of this only being available to mouse users.Previously this would be handled in the code of an app that uses the addon by wrapping the tooltip and manually showing/hiding it based on focus/blur events.
Added tests around the
show
arg as I accidentally broke this behaviour but tests didn't catch it.Areas for review
General thoughts +
Does it make sense to combine the event listeners for mouse/keyboard? (ie. just use a single handler and
isOverTooltipper
variable), and then whether or not keyboard is supported would be handled purely by whether or not the event listeners have been added or notHave I missed any places worth testing?