Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: install node types and remove lib.dom.d.ts from tsconfig #23

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

zirkelc
Copy link
Owner

@zirkelc zirkelc commented Nov 6, 2024

This library was relying on the fetch types from lib.dom.d.ts available from the tsconfig.json.
As this library is mostly used in a Node.js environment, it makes sense to use the official fetch types from Node.js which import the official types from unidici (#22)

Copy link

github-actions bot commented Nov 6, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 100% (🎯 80%) 97 / 97
🟢 Statements 100% (🎯 80%) 97 / 97
🟢 Functions 100% (🎯 80%) 3 / 3
🟢 Branches 94.73% (🎯 80%) 36 / 38
File CoverageNo changed files found.
Generated in workflow #85 for commit 6c4110c by the Vitest Coverage Report Action

@zirkelc zirkelc merged commit 88b3f4b into main Nov 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant