Fix Python 3.10 errors #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing.Self requires Python 3.11. Replaced it with the class name for types that aren't subclassed or a TypeVar for types that are. The type annotation on Hardware.from_dict() must be given as a string, or pyupgrade will convert it to type[_Self], which breaks because Hardware has a member named "type" (which cannot be renamed since it must match the name of the YAML files the class represents). Fixes zmkfirmware#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing.Self requires Python 3.11. Replaced it with the class name for types that aren't subclassed or a TypeVar for types that are.
The type annotation on Hardware.from_dict() must be given as a string, or pyupgrade will convert it to type[_Self], which breaks because Hardware has a member named "type" (which cannot be renamed since it must match the name of the YAML files the class represents).
Fixes #9