Bugfix: Trigger onChangeObjEvt on Obj move (#157) #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmsdev
reviewed
Jul 26, 2023
| @@ -73,7 +73,7 @@ | |||
| </tal:block> | |||
| <div class="dropdown-divider"></div> | |||
| <a class="dropdown-item" href="manage_zmi_logout" data-turbolinks="false" | |||
| tal:attributes="href python:'{}?lang={}'.format(here.getConfProperty('ZMS.logout.href',''),request['lang']) if here.getConfProperty('ZMS.logout.href','')!='' else 'manage_zmi_logout'; | |||
| tal:attributes="href python:'{}?lang={}&__ac_name={}'.format(here.getConfProperty('ZMS.logout.href',''),request['lang'],request.get('AUTHENTICATED_USER')) if here.getConfProperty('ZMS.logout.href','')!='' else 'manage_zmi_logout'; | |||
There was a problem hiding this comment.
this does not seem to be related to this PR's subject
zmsdev
requested changes
Jul 26, 2023
|
its not a change on the obj but its a change on parent because the order of the children is changed. But the PR doesnt solve the problem of the parent :-) |
|
The Changes on Products/zms/zpt/common/zmi_body_header.zpt are outdatet and the PR contains only the cahnges on onChangeObjEvt #158 1cde313 |
|
Please resolve conflicts in zmsobject.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If manage_movexxx is called there is no other method, which triggers onChangeObjEvt, so we added it in each method.