Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog-Adapter: custom filter-function - only active objects #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zmsdev
Copy link
Contributor

@zmsdev zmsdev commented Feb 14, 2024

Filter may reduce performance massively
https://github.com/idasm-unibe-ch/unibe-cms-opensearch/issues/21
As major reason, inactive sub-trees from catalog should be exluded by default.

@zmsdev zmsdev added the enhancement New feature or request label Feb 14, 2024
@zmsdev zmsdev self-assigned this Feb 14, 2024
@zmsdev zmsdev requested a review from drfho February 14, 2024 17:19
Copy link
Contributor

@drfho drfho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduces permanent breadcrumb iterations in the filter
LGTM

@drfho
Copy link
Contributor

drfho commented Feb 15, 2024

latest considerations do not see here a significant perf prob
https://github.com/idasm-unibe-ch/unibe-cms-opensearch/issues/21#issuecomment-1945534171
but the absence of tika service.

So, I suggest to set this RR on hold.

@drfho drfho added the wontfix This will not be worked on label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants