Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable single mode #272

Merged
merged 6 commits into from
Mar 19, 2024
Merged

enable single mode #272

merged 6 commits into from
Mar 19, 2024

Conversation

loechel
Copy link
Member

@loechel loechel commented Feb 29, 2024

resolves #271

@loechel loechel self-assigned this Feb 29, 2024
@loechel loechel requested a review from icemac February 29, 2024 15:53
icemac
icemac approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the test names a bit more in line with the other ones in the module. (The description of the test should be in the docstring, not in the test name.)

tests/test_compile.py Outdated Show resolved Hide resolved
tests/test_compile.py Outdated Show resolved Hide resolved
icemac
icemac requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a change log entry and a bit of documentation like you wrote in the ticket?

@loechel loechel requested a review from icemac March 14, 2024 20:54
@icemac
Copy link
Member

icemac commented Mar 19, 2024

Thank you for this PR. 😃

@icemac icemac merged commit 86f63a5 into master Mar 19, 2024
23 of 25 checks passed
@icemac icemac deleted the single_mode branch March 19, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees

@loechel loechel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to compile single expressions
2 participants
@loechel @icemac