test: Check all vCPUs are oneline

As seen in firecracker-microvm#4925, a bad CPU template made secondary CPUs not come up. To catch similar bugs of CPU templates, check all the vCPUs are online from guests' perspective. Signed-off-by: Takahiro Itazuri <[email protected]>
zulinx86 · Dec 4, 2024 · fa07e9f · fa07e9f
1 parent c181b69
commit fa07e9f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/tests/framework/microvm.py b/tests/framework/microvm.py
@@ -938,6 +938,7 @@ def make_snapshot(
             ssh_key=self.ssh_key,
             snapshot_type=snapshot_type,
             meta={
+                "vcpus_count": self.vcpus_count,
                 "kernel_file": self.kernel_file,
             },
         )

diff --git a/tests/integration_tests/functional/test_cpu_multiple.py b/tests/integration_tests/functional/test_cpu_multiple.py
@@ -0,0 +1,19 @@
+# Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+
+"""
+Test all vCPUs are configured correctly and work properly.
+
+This test suite aims to catch bugs of Firecracker's vCPU configuration and
+CPU templates especially under multi-vCPU setup, by checking that all vCPUs
+are operating identically, except for the expected differences.
+"""
+
+import pytest
+
+
+def test_all_vcpus_online(uvm_any):
+    """Check all vCPUs are online inside guest"""
+    vm = uvm_any
+    for idx in range(vm.vcpus_count):
+        assert vm.ssh.check_output(f"cat /sys/devices/system/cpu/cpu{idx}/online").stdout == "1\n"