#245 Add the ability to query REST endpoints from Reader module #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created new module Info * the new modul added to JaCoco and CI routines
* JaCoCo exclusion for model
* created Provider to query the data from server * support for Future, IO, and ZIO based providers * work in progress
benedeki
added
the
work in progress
* fixed license headers
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo reader module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
benedeki
commented
Nov 6, 2024
reader/src/main/scala/za/co/absa/atum/reader/server/GenericServerConnection.scala
Outdated
Show resolved
Hide resolved
model/src/main/scala/za/co/absa/atum/model/utils/JsonSyntaxExtensions.scala
Outdated
Show resolved
Hide resolved
model/src/test/scala/za/co/absa/atum/testing/implicits/StringImplicits.scala
Outdated
Show resolved
Hide resolved
reader/src/main/scala-2.13/za/co/absa/atum/reader/implicits/zio.scala
Outdated
Show resolved
Hide resolved
reader/src/main/scala/za/co/absa/atum/reader/implicits/io.scala
Outdated
Show resolved
Hide resolved
reader/src/test/scala-2.13/za/co/absa/atum/reader/basic/Reader_ZIOUnitTests.scala
Outdated
Show resolved
Hide resolved
reader/src/test/scala/za/co/absa/atum/reader/basic/Reader_CatsIOUnitTests.scala
Outdated
Show resolved
Hide resolved
reader/src/main/scala/za/co/absa/atum/reader/basic/Reader.scala
Outdated
Show resolved
Hide resolved
reader/src/main/scala/za/co/absa/atum/reader/basic/ReaderWithPartitioningId.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
Nov 25, 2024
lsulak
reviewed
Nov 25, 2024
lsulak
reviewed
Nov 25, 2024
model/src/main/scala/za/co/absa/atum/model/utils/JsonSyntaxExtensions.scala
Show resolved
Hide resolved
ABLL526
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Should we not add some failure tests as well?
There was a problem hiding this comment.
The test now doesn't really test anything. They just ensure coverage numbers 🙄 .
The whole class is just a shell now, content will come in future tickets.
There was a problem hiding this comment.
Should we not add some failure tests as well?
There was a problem hiding this comment.
Ditto, just a shell of class.
salamonpavel
reviewed
Dec 3, 2024
reader/src/test/scala/za/co/absa/atum/reader/basic/PartitioningIdProviderUnitTests.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Ladislav Sulak <[email protected]>
…endpoints-from-info-module
salamonpavel
previously approved these changes
Dec 4, 2024
lsulak
reviewed
Dec 4, 2024
lsulak
reviewed
Dec 4, 2024
reader/src/main/scala/za/co/absa/atum/reader/PartitioningReader.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
Dec 4, 2024
reader/src/main/scala/za/co/absa/atum/reader/basic/Reader.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
Dec 4, 2024
reader/src/test/scala/za/co/absa/atum/reader/FlowReaderUnitTests.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
Dec 4, 2024
reader/src/test/scala/za/co/absa/atum/reader/PartitioningReaderUnitTests.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Ladislav Sulak <[email protected]>
lsulak
approved these changes
Dec 4, 2024
benedeki
deleted the
feature/245-add-the-ability-to-query-rest-endpoints-from-info-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReaderandPartitioningIdProviderbase classes for all readers - they are to bringAtum server connectivity/querying abilityRequestResult[R]represents an Atum server query response.MonadErrortype class needed forReaderandReaderWithPartitioningId- there areFuture, CatsIOAtumPartitionsandAdditionalDatamoved from Agent to ModuleErrorResponsereceived a method to decode from Json based on http status codeCloses #245
Depends on #300
Release Notes: