Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AKSCONFIG variable check #112

Closed
wants to merge 1 commit into from
Closed

Fix AKSCONFIG variable check #112

wants to merge 1 commit into from

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented May 8, 2024

What this PR does

dev-infrastructure make commands weren't working because ifndef only functions outside of make targets. Now, it works as intended

@s-amann
Copy link
Contributor

s-amann commented May 8, 2024

@mjlshen PR #113 addressed the makefile issue, can you pull down main and check if this also resolves it for you?

@mjlshen
Copy link
Contributor Author

mjlshen commented May 8, 2024

The intent was to not require AKSCONFIG for some targets (list, fmt, lint) #113 does fix it for the rest of the targets that should require the variable

@mjlshen mjlshen force-pushed the make branch 2 times, most recently from 9770044 to 659a3bf Compare May 8, 2024 17:59
@s-amann
Copy link
Contributor

s-amann commented May 8, 2024

The intent was to not require AKSCONFIG for some targets (list, fmt, lint) #113 does fix it for the rest of the targets that should require the variable

I'm able to run make lint without having AKSCONFIG set

@mjlshen mjlshen closed this May 8, 2024
@mjlshen mjlshen deleted the make branch June 17, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants