Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifndef indentation issue #113

Merged
merged 1 commit into from
May 8, 2024
Merged

ifndef indentation issue #113

merged 1 commit into from
May 8, 2024

Conversation

geoberle
Copy link
Collaborator

@geoberle geoberle commented May 8, 2024

tabbed conditionals seem to be unsupported in make (or at least the make version i have locally). when using tabs to indent the ifndef for AKSCONFIG i get the following error.

AKSCONFIG=abc make sv-cluster

Makefile:41: *** "Must set AKSCONFIG". Stop

in order to not start an argument about "tabs vs spaces" and about "how many spaces", i removed the tabs. the makefile syntax seems to be fine with it.

What this PR does

Before this PR:

After this PR:

Jira:
Link to demo recording:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

  • PR: The PR description is expressive enough and will help future contributors
  • Code: Write code that humans can understand and Keep it simple
  • Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
  • Upgrade: Impact of this change on upgrade flows was considered and addressed if required
  • Deployment: The deployment process was considered and addressed if required
  • Testing: New code requires new unit tests.
  • Documentation: Is the documentation updated? Either in the doc located in focus area, in the README or in the code itself.
  • Customers: Is this change affecting customers? Is the release plan considered?

tabbed conditionals seem to be unsupported in make (or at least the
make version i have locally). when using tabs to indent the ifndef for
ASCONFIG i get the following error.

```shell
AKSCONFIG=abc make sv-cluster

Makefile:41: *** "Must set AKSCONFIG". Stop
```

in order to not start an argument about "tabs vs spaces" and about "how many
spaces", i removed the tabs. the makefile syntax seems to be fine with it.
@geoberle geoberle marked this pull request as ready for review May 8, 2024 17:38
@s-amann s-amann merged commit 9e9068d into Azure:main May 8, 2024
3 checks passed
@mjlshen
Copy link
Contributor

mjlshen commented May 8, 2024

Ah trying to fix this in #112 - it's not intended to be all the way to the left

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants