*: add acrpull controller, binding #986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
requested review from
bennerv,
mbarnes,
SudoBrendan,
jharrington22,
UlrichSchlueter and
zgalor
as code owners
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
from
d6cc31c to
c4d9916
Compare
stevekuznetsov
requested review from
geoberle,
janboll,
weinong,
whober0521 and
tony-schndr
as code owners
stevekuznetsov
commented
Dec 13, 2024
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
from
c4d9916 to
d624ad5
Compare
stevekuznetsov
requested review from
jmelis,
jonathan34c and
nwnt
as code owners
stevekuznetsov
commented
Dec 13, 2024
| @@ -460,15 +460,26 @@ resource uami_fedcred 'Microsoft.ManagedIdentity/userAssignedIdentities/federate | |||
| parent: uami[i] | |||
| name: '${workloadIdentities[i].value.uamiName}-${location}-fedcred' | |||
| properties: { | |||
| audiences: [ | |||
There was a problem hiding this comment.
@geoberle please provide feedback on all this
|
Please rebase pull request. |
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
2 times, most recently
from
716fe93 to
5c1de8a
Compare
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
from
5c1de8a to
a1b1fbe
Compare
stevekuznetsov
commented
Dec 19, 2024
| workloadIdentity: | ||
| serviceAccountRef: frontend | ||
| clientID: {{ .Values.pullBinding.workloadIdentityClientId }} | ||
| tenantID: {{ .Values.pullBinding.workloadIdentityTenantId }} |
There was a problem hiding this comment.
Newest version of the controller allows us to reference the puller's MI for this token, letting multiple MI to be federated to the SA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Jira:
Link to demo recording:
Special notes for your reviewer