Capybara/ClickLinkOrButtonStyle: Enforce strict style #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule's default enforce style, `link_or_button` [1], introduced a number of problems [2]. Specifically, I noticed issues switching to `click_on` from `click_button` [3]. The hack solution is to ignore or disable the rule in some places but not in others. Not great. As a result, the rule is slated for removal [4] and replacement [5] by a new rule. In the interim, configuring this rule to enforce a strict use of `click_button` and `click_link` is preferential (and, honestly, more communicative). In this author's opinion, user interface specs should be explicit about the markup under test. [1] https://docs.rubocop.org/rubocop-capybara/cops_capybara.html#capybaraclicklinkorbuttonstyle [2] rubocop/rubocop-capybara#61 [3] rubocop/rubocop-capybara#61 (comment) [4] rubocop/rubocop-capybara#81 [5] rubocop/rubocop-capybara#99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This rule's default enforce style,
link_or_button[1], introduced a number of problems [2]. Specifically, I noticed issues switching toclick_onfromclick_button[3]. The hack solution is to ignore or disable the rule in some places but not in others. Not great.As a result, the rule is slated for removal [4] and replacement [5] by a new rule. In the interim, configuring this rule to enforce a strict use of
click_buttonandclick_linkis preferential (and, honestly, more communicative).In this author's opinion, user interface specs should be explicit about the markup under test.
[1] https://docs.rubocop.org/rubocop-capybara/cops_capybara.html#capybaraclicklinkorbuttonstyle
[2] rubocop/rubocop-capybara#61
[3] rubocop/rubocop-capybara#61 (comment)
[4] rubocop/rubocop-capybara#81
[5] rubocop/rubocop-capybara#99
Commits
Capybara/ClickLinkOrButtonStyle