Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capybara/ClickLinkOrButtonStyle: Enforce strict style #32

Merged
merged 2 commits into from
May 6, 2024
Merged

Capybara/ClickLinkOrButtonStyle: Enforce strict style #32

merged 2 commits into from
May 6, 2024

Commits on May 6, 2024

  1. Configure Capybara/ClickLinkOrButtonStyle 

    This rule's default enforce style, `link_or_button` [1], introduced a
number of problems [2]. Specifically, I noticed issues switching to
`click_on` from `click_button` [3]. The hack solution is to ignore or
disable the rule in some places but not in others. Not great.

As a result, the rule is slated for removal [4] and replacement [5] by
a new rule. In the interim, configuring this rule to enforce a strict
use of `click_button` and `click_link` is preferential (and, honestly,
more communicative).

In this author's opinion, user interface specs should be explicit about
the markup under test.

[1] https://docs.rubocop.org/rubocop-capybara/cops_capybara.html#capybaraclicklinkorbuttonstyle
[2] rubocop/rubocop-capybara#61
[3] rubocop/rubocop-capybara#61 (comment)
[4] rubocop/rubocop-capybara#81
[5] rubocop/rubocop-capybara#99
    @jgarber623-cargosense
    jgarber623-cargosense committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d368a64 View commit details
    Browse the repository at this point in the history

  2. Bump version to v1.1.0

    @jgarber623-cargosense
    jgarber623-cargosense committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ede13c8 View commit details
    Browse the repository at this point in the history