Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pv7 conformance #384

Merged
merged 16 commits into from
Aug 29, 2024
Merged

Pv7 conformance #384

merged 16 commits into from
Aug 29, 2024

Conversation

soerenbf
Copy link
Collaborator

@soerenbf soerenbf commented Aug 27, 2024 •
edited
Loading

Purpose

Update the SDK to conform to the changes introduced to the node API with protocol version 7

Closes #383

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@soerenbf soerenbf self-assigned this Aug 27, 2024
soerenbf
soerenbf commented Aug 28, 2024
View reviewed changes
packages/sdk/src/types.ts Outdated Show resolved Hide resolved
@soerenbf soerenbf requested a review from limemloh August 28, 2024 06:38
@soerenbf soerenbf marked this pull request as ready for review August 28, 2024 06:38
@soerenbf soerenbf changed the base branch from main to release/web-sdk/8 August 28, 2024 08:17
limemloh
limemloh approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work adding more documentation to types 🙏

packages/sdk/src/grpc/translation.ts Show resolved Hide resolved
packages/sdk/src/grpc/translation.ts Show resolved Hide resolved
packages/sdk/src/types.ts Outdated Show resolved Hide resolved
@soerenbf soerenbf requested a review from limemloh August 28, 2024 09:26
@soerenbf soerenbf mentioned this pull request Aug 28, 2024
Merged
7 tasks
@soerenbf soerenbf merged commit 508ec9f into release/web-sdk/8 Aug 29, 2024
10 checks passed
@soerenbf soerenbf deleted the pv7-conformance branch August 29, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limemloh limemloh limemloh approved these changes

Assignees

@soerenbf soerenbf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align TransactionType enum with GRPC api types
2 participants
@soerenbf @limemloh