web SDK v8 #385
Merged
web SDK v8 #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#233) ## Purpose Ensure that `getEmbeddedSchema` (on `ConcordiumGRPCClient`) is able to resolve legacy schemas (i.e. schemas without embedded versions). Also make parsing of contract schema more precise based by using the module version information that is now exposed by the gRPC client. This in turn also documents the relationship between module and schema versions. ## Changes The module version is now used to determine what custom sections to look for. Added comments explain the expected results. The extraction code is migrated from the dapp-library [`@concordium/react-components`](https://github.com/Concordium/concordium-dapp-libraries/blob/a045f3b8bc11c7389190c789072f313686b6c639/packages/react-components/src/useModuleSchemaRpc.ts). Specifically, the contents of function `getEmbeddedModuleSchema` was replaced with the contents of `findSchema` and its helper function `findCustomSections` was added and adjusted to use the SDK types. Finally, `getEmbeddedModuleSchema` was made non-async and `wasmToSchema` removed because it was nothing but a more limited version of `getEmbeddedModuleSchema`. Addresses Concordium/concordium-dapp-libraries#66.
`concordium-grpc-api`
This reverts commit affcd78.
soerenbf
commented
Aug 28, 2024
soerenbf
force-pushed
the
release/web-sdk/8
branch
from
ea4d193 to
e75709b
Compare
soerenbf
force-pushed
the
release/web-sdk/8
branch
from
4f35afe to
24fa230
Compare
Add fallback for available balance to be compatible with node version 6
|
Release schedule has been more or less removed as backwards compatibility was implemented in #389 to support the browser wallet in conformance to node version 7. |
limemloh
reviewed
Sep 10, 2024
limemloh
reviewed
Sep 10, 2024
limemloh
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT
This should not be merged until the concordium node v7.0 has been released for mainnet. The release schedule below should be followed
SDK v8 Release schedule
@concordium/web-sdk@alpha= local/stagenet node 7.0 release@concordium/web-sdk@latest= as soon as this has been mergedChanges
Checklist
hard-to-understand areas.