Remove inner checksum in pegin descriptor #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCasatta
force-pushed
the
inner_checksum
branch
from
a79b7b0 to
d8a539d
Compare
RCasatta
force-pushed
the
inner_checksum
branch
from
d8a539d to
fe43086
Compare
Merged
apoelstra
added a commit
that referenced
this pull request
Dec 7, 2024
624e3f4 create an address matching the fed desc (Riccardo Casatta) 59362c8 remove unused lint cfg causing warning (Riccardo Casatta) 2f1e07b Add Pegin::derived_descriptor (Riccardo Casatta) f77617b Refactor out the fed peg desc in a function (Riccardo Casatta) 1a22725 Remove generic in Pegin descriptor for `fed_desc` (Riccardo Casatta) Pull request description: On top of #95 draft PR to investigate the derivability of a bunch of addresses from a pegin descriptor. Use the following assumption * federation descriptor is using only `bitcoin::PublicKey` ACKs for top commit: apoelstra: ACK 624e3f4; successfully ran local tests Tree-SHA512: 8861ff169aac8867c96c0950a2898b89f2a2aa35f3dff8ec11bc78f3d0cc2b6f0207a489637338f8df65b9c4ac5e947c1077a918d3aea3ffe1e70aebadcdbf7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in the pegin descriptor inner checksum are printed, for example:
pegin(feddesc#cheksum, elem_desc#cheksum)#checksumand this changes it to
pegin(feddesc, elem_desc)#checksum