Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OoT] Fix Cutscene Main obj empty type upgrade issues #290

Merged
merged 2 commits into from
May 22, 2024

Conversation

Yanis002
Copy link
Contributor

found this while doing some export tests, there was 2 issues:

  1. the call of the upgrade function was in the wrong if block, this made it impossible to reach
  2. the upgrade code did not account for the new enum data that was introduced recently, so it was shifting the enum index for no reasons

I addressed these issues with the following changes:

  • for issue 1. I simply moved the if statement in the correct block
  • for issue 2. I removed the shifting, I moved the "custom" enum value +1 after the value checks and I updated the exclusion list to exclude the unimplemented values (it raises an index error and default to "custom" to keep the previous data)

I made an addition to that, I added a check for the unlikely case where the values are fine (so no index error raised) but it's out of the range of the enum list, if this case happens it should raise a plugin error showing which prop (with the new name) failed (the condition is set to True if it's reaching the except block when it sets custom values)

@Yanis002 Yanis002 added oot Has to do with the Ocarina of Time 64 side bug Something isn't working labels Jan 10, 2024
@Yanis002 Yanis002 added this to the v2.2.1 milestone May 19, 2024
@Dragorn421 Dragorn421 added the merge soon Will be merged in a few days at most if nothing else comes up label May 20, 2024
@Dragorn421 Dragorn421 merged commit e4aff74 into Fast-64:main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up oot Has to do with the Ocarina of Time 64 side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants