Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OoT] Implemented quick cutscene import and single cutscene import #297

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

Yanis002
Copy link
Contributor

This also fix a minor issue related to player cues. Since it would be literally the same class I decided to make the "import all cutscenes" a 2-in-1 operator, if the cutscene name for single import is blank then it will import everything (and warn the user with a label)

@Yanis002 Yanis002 added the oot Has to do with the Ocarina of Time 64 side label Jan 16, 2024
@Yanis002 Yanis002 added this to the v2.2.2 milestone May 31, 2024
@Dragorn421
Copy link
Contributor

Trying to import gHyruleFieldGetOoTCs doesn't work, with or without having the scene imported first (without cutscenes), using QuickImport or the dedicated operator
:(

Error: Python: Traceback (most recent call last):
  File "/home/dragorn421/.config/blender/4.2/scripts/addons/fast64_gitlinked/fast64_internal/oot/tools/operators.py", line 288, in execute
    quick_import_exec(
  File "/home/dragorn421/.config/blender/4.2/scripts/addons/fast64_gitlinked/fast64_internal/oot/tools/quick_import.py", line 131, in quick_import_exec
    bpy.context.scene.ootCSNumber = importCutsceneData(f"{sym_file_p}", None, sym_name)
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dragorn421/.config/blender/4.2/scripts/addons/fast64_gitlinked/fast64_internal/oot/cutscene/importer/functions.py", line 11, in importCutsceneData
    return csMotionImport.setCutsceneData(bpy.context.scene.ootCSNumber)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dragorn421/.config/blender/4.2/scripts/addons/fast64_gitlinked/fast64_internal/oot/cutscene/importer/classes.py", line 482, in setCutsceneData
    cutsceneList = self.getCutsceneList()
                   ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dragorn421/.config/blender/4.2/scripts/addons/fast64_gitlinked/fast64_internal/oot/cutscene/importer/classes.py", line 196, in getCutsceneList
    parsedCutscenes = self.getParsedCutscenes()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dragorn421/.config/blender/4.2/scripts/addons/fast64_gitlinked/fast64_internal/oot/cutscene/importer/classes.py", line 123, in getParsedCutscenes
    csData[-1] += line
    ~~~~~~^^^^
IndexError: list index out of range

@Yanis002
Copy link
Contributor Author

should work now

@Dragorn421 Dragorn421 added the merge soon Will be merged in a few days at most if nothing else comes up label Aug 19, 2024
@Dragorn421 Dragorn421 merged commit 9f724a8 into Fast-64:main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge soon Will be merged in a few days at most if nothing else comes up oot Has to do with the Ocarina of Time 64 side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants