[SM64] - Fix animation translation #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://discord.com/channels/874816709855440926/874818719220633672/1197010611788333117 was also caused by the old logic, animation exports properly with this pr |
|
Just had confirmation of another person having issues fixed from this, I'm waiting on kaze to confirm this fixes his animations too! |
jesusyoshi54
approved these changes
Jan 19, 2024
|
Working on it miss 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this method in my own branches, it works and it fixes translation issues (see https://discord.com/channels/874816709855440926/1196963740705357894), along with being faster