Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidify checking materials assigned to faces #304

Merged

Conversation

Dragorn421
Copy link
Contributor

if material_index >= len(material_slots): (not sure how to reproduce a blend triggering this, I got one in DMs from someone)
image

if material is None: (slot without a material)
image

if not material.is_f3d: (material isn't f3d)
image

@Dragorn421 Dragorn421 added the f3d Has to do with the "f3d" code common to all games label Jan 31, 2024
Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine

@Dragorn421 Dragorn421 added the merge soon Will be merged in a few days at most if nothing else comes up label Feb 5, 2024
@Dragorn421 Dragorn421 merged commit c7ee1fb into Fast-64:main Feb 7, 2024
1 check passed
@Dragorn421 Dragorn421 deleted the solidify_material_assigned_check branch February 7, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f3d Has to do with the "f3d" code common to all games merge soon Will be merged in a few days at most if nothing else comes up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants