[F3D] Fix RDP world defaults #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the ucode default, so having this set to NOISE is a weird choice that also breaks SM64 (please confirm this doesn´t affect OOT please)
gheskett
approved these changes
Jul 10, 2024
|
Draft until a good solution for game mode world defaults is implemented aha |
…te based on game mode
Lilaa3
changed the title
assume every geo mode is off for oot formatting and grammar fix Make world defaults draw into one function, add better text and homebrew mode warning two cycle in oot
This reverts commit c66f4b6.
Yanis002
requested changes
Aug 2, 2024
|
where is |
|
I should add that the scene world is picked in the world properties tab |
Yanis002
approved these changes
Aug 2, 2024
Yanis002
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T̶h̶i̶s̶ ̶i̶s̶ ̶t̶h̶e̶ ̶u̶c̶o̶d̶e̶ ̶d̶e̶f̶a̶u̶l̶t̶,̶ ̶s̶o̶ ̶h̶a̶v̶i̶n̶g̶ ̶t̶h̶i̶s̶ ̶s̶e̶t̶ ̶t̶o̶ ̶N̶O̶I̶S̶E̶ ̶i̶s̶ ̶a̶ ̶w̶e̶i̶r̶d̶ ̶c̶h̶o̶i̶c̶e̶ ̶t̶h̶a̶t̶ ̶a̶l̶s̶o̶ ̶b̶r̶e̶a̶k̶s̶ ̶S̶M̶6̶4̶ ̶(̶p̶l̶e̶a̶s̶e̶ ̶c̶o̶n̶f̶i̶r̶m̶ ̶t̶h̶i̶s̶ ̶d̶o̶e̶s̶n̶´̶t̶ ̶a̶f̶f̶e̶c̶t̶ ̶O̶O̶T̶ ̶p̶l̶e̶a̶s̶e̶)̶
World defaults need to vary across game modes, this pr will try to focus on that from now