Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM64] Only throw empty gfx exception in actor exports #413

Merged
merged 9 commits into from
Dec 28, 2024

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Aug 9, 2024

Oh lila LOVESSS breaking main RIGHT SCUT?

@Lilaa3 Lilaa3 added bug Something isn't working sm64 Has to do with the Super Mario 64 side labels Aug 9, 2024
Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works and the code is simple enough.

On an somewhat unrelated note, the exportGeolayoutArmature have camera arguments with some esoteric uses that are lost to time and never used. This should be cleaned up at some point.

fast64_internal/sm64/sm64_geolayout_writer.py Show resolved Hide resolved
@Lilaa3 Lilaa3 requested a review from jesusyoshi54 August 21, 2024 11:25
@jesusyoshi54
Copy link
Collaborator

When you call exportGeolayoutObjectBinaryBank0 it still has the camera argument present. Same with exportGeolayoutObjectBinary and exportGeolayoutObjectC

Traceback (most recent call last):
  File "C:\Users\scut\Desktop\fast64-main\addons\fast64\fast64_internal\sm64\sm64_objects.py", line 1854, in execute
    self.execute_gfx(props, context, obj, index)
  File "C:\Users\scut\Desktop\fast64-main\addons\fast64\fast64_internal\sm64\sm64_objects.py", line 1843, in execute_gfx
    raise Exception(e)
Exception: Error: exportGeolayoutObjectC() takes 13 positional arguments but 14 were given

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 23, 2024

sorry about that I will pay more attention next time

Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported object and area, plus extra empty area. compiles and boots

@jesusyoshi54 jesusyoshi54 added the merge soon Will be merged in a few days at most if nothing else comes up label Dec 22, 2024
@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Dec 28, 2024

@jesusyoshi54 now that i think about it, would a separate pr for collision be fine?

@jesusyoshi54
Copy link
Collaborator

what would that PR be for?

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Dec 28, 2024

@jesusyoshi54 basically the same thing i guess

@jesusyoshi54
Copy link
Collaborator

jesusyoshi54 commented Dec 28, 2024 via email

@Lilaa3 Lilaa3 merged commit 60bdf25 into Fast-64:main Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up sm64 Has to do with the Super Mario 64 side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants