-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM64] Only throw empty gfx exception in actor exports #413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it works and the code is simple enough.
On an somewhat unrelated note, the exportGeolayoutArmature
have camera arguments with some esoteric uses that are lost to time and never used. This should be cleaned up at some point.
When you call Traceback (most recent call last):
File "C:\Users\scut\Desktop\fast64-main\addons\fast64\fast64_internal\sm64\sm64_objects.py", line 1854, in execute
self.execute_gfx(props, context, obj, index)
File "C:\Users\scut\Desktop\fast64-main\addons\fast64\fast64_internal\sm64\sm64_objects.py", line 1843, in execute_gfx
raise Exception(e)
Exception: Error: exportGeolayoutObjectC() takes 13 positional arguments but 14 were given |
sorry about that I will pay more attention next time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported object and area, plus extra empty area. compiles and boots
@jesusyoshi54 now that i think about it, would a separate pr for collision be fine? |
what would that PR be for? |
@jesusyoshi54 basically the same thing i guess |
I don't see a need for it tbh but I guess you can make it. Helpful for menu
type levels maybe. I would make it a new PR though if you want to do it.
…On Sat, Dec 28, 2024, 1:09 PM Lila ***@***.***> wrote:
@jesusyoshi54 <https://github.com/jesusyoshi54> basically the same thing
i guess
—
Reply to this email directly, view it on GitHub
<#413 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTTURRCG6AMSPI3ED2LQWL2H3SOTAVCNFSM6AAAAABMH53UGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGM4TGNZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Oh lila LOVESSS breaking main RIGHT SCUT?