Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating 2D discrete fields #22

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Gornhoth
Copy link

The 2D generation works almost exactly like the 3D one. The signatures were matched as closely as possible and programs are included similar to the 3D solution (GenerateSDF2D, DiscreteFieldToBitmap2D).
Note that for the examples Clipper2 library is used to convert a triangle mesh to a polygon before discretization. However, this dependency is optional and the solution (without the two programs) works without it as well, if the user defines their own polygon structure consistent of vertices and edges to discretize.
If anything in my code is not to up to the standards of the maintainers of Discregrid, please tell me how I can fix things so this pull request can be merged.

@JoseAntFer
Copy link
Member

Hello,

thank you for your contribution, however, at the moment I have no time to revise the changes. I will leave it open for now.

@Gornhoth
Copy link
Author

Hello!
Thanks for the information, please take your time to review the changes, there is no need to hurry if there is little time at the moment. For my personal interest, may I ask in what time frame it is likely my pull request can be reviewed?

@JoseAntFer
Copy link
Member

Sadly, I am not able to give you a time frame as we have a couple of packed months coming. Additionally, we have to discuss internally if we actually want to add support for 2D fields in the main repo of Discregrid as we do not work with 2D and it just becomes more code to maintain for us.

@Gornhoth
Copy link
Author

Understandable, thanks for the information and good luck with your upcoming projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants