-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul frame props plugin #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i'd also make it possible to show VideoFrame at this point |
I really like that idea, but I'm not sure I'll do that as part of this PR. |
If there's no qualms about this PR besides the videoframe pop-out thing (which can easily be moved to a different PR), I'll be merging this in the following days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
Screenshots:
Categories and props
The following categories were added, and these props get sorted into them automatically:
Video
For the most part clip-wide properties that shouldn't change (much) per frame
Metrics
Generic metrics, such as from PlaneStats or SceneChange detection plugins
Field
Direct IVTC/deinterlacing-related props
Other
Anything else that doesn't get caught by the filters.
Prettified props:
The following props get prettified:
Basic
VIVTC/TIVTC/dmetrics
Packet Sizes
Adding the rest later...