add tests for test package #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
also: • fix ExitStatus for test package • Allow POST for test package
jgramoll
force-pushed
the
add_test_for_test
branch
from
2ef3eae
to
4727578
Compare
jgramoll
commented
Jun 30, 2021
| @@ -119,7 +119,7 @@ func MockFunc(e mockEnvironment) net.Conn { | |||
| for { | |||
| d, err := readPbFrame(conB) | |||
| if err != nil { | |||
| e.Errorf("Can't read method name") | |||
| // Conn probably closed | |||
There was a problem hiding this comment.
I was getting an error with go test -race trying to access e from this goroutine. Open to ideas how to fix this better, but it got my tests working
jgramoll
commented
Jun 30, 2021
| if req.Body != "" { | ||
| return fmt.Errorf("GET requests must not have body, found \"%v\"", req.Body) | ||
| } | ||
| return nil | ||
| case "POST": | ||
| return nil | ||
| default: |
There was a problem hiding this comment.
Is there a reason to only whitelist certain methods?
There was a problem hiding this comment.
Looks like unfinished code.
jgramoll
commented
Jun 30, 2021
| @@ -442,9 +446,9 @@ func (e *TestEnv) Handle(method string, args_d []byte) []byte { | |||
| args := kong_plugin_protocol.ExitArgs{} | |||
| e.noErr(proto.Unmarshal(args_d, &args)) | |||
| e.ClientRes.Status = int(args.Status) | |||
| e.state = finished | |||
There was a problem hiding this comment.
ExitStatus was not finishing
|
@fffonion please review |
|
Hi. @jgramoll Do you still want to push this forward? Please rebase the branch and solve the conflict. |
|
Opened #196 picking the changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also:
• fix ExitStatus for test package
• Allow POST for test package