add tests for test package

bridge/bridgetest/bridgetest.go

@@ -119,7 +119,7 @@ func MockFunc(e mockEnvironment) net.Conn {
 		for {
 			d, err := readPbFrame(conB)
 			if err != nil {
-				e.Errorf("Can't read method name")
+				// Conn probably closed
 				break
 			}
 			method := string(d)
@@ -137,10 +137,6 @@ func MockFunc(e mockEnvironment) net.Conn {
 				e.Errorf("Can't write back return values")
 				break
 			}
-
-			if !e.IsRunning() {
-				break
-			}
 		}
 	}()
 	return conA

test/test.go

@@ -110,13 +110,17 @@ func (req *Request) Validate() error {
 
 	req.Headers = mergeHeaders(make(http.Header), req.Headers)
 
-	if req.Method == "GET" {
+	switch req.Method {
+	case "GET":
 		if req.Body != "" {
 			return fmt.Errorf("GET requests must not have body, found \"%v\"", req.Body)
 		}
 		return nil
+	case "POST":
+		return nil
+	default:
+		return fmt.Errorf("unsupported method \"%v\"", req.Method)
 	}
-	return fmt.Errorf("Unsupported method \"%v\"", req.Method)
 }
 
 func getPort(u *url.URL) int32 {
@@ -442,9 +446,9 @@ func (e *TestEnv) Handle(method string, args_d []byte) []byte {
 		args := kong_plugin_protocol.ExitArgs{}
 		e.noErr(proto.Unmarshal(args_d, &args))
 		e.ClientRes.Status = int(args.Status)
+		e.state = finished
+		e.ClientRes.Body = args.Body
 		if args.Headers != nil {
-			e.state = finished
-			e.ClientRes.Body = args.Body
 			headers := bridge.UnwrapHeaders(args.Headers)
 			mergeHeaders(e.ClientRes.Headers, headers)
 		}

test/test_test.go

@@ -0,0 +1,77 @@
+package test
+
+import (
+	"net/http"
+	"testing"
+
+	"github.com/Kong/go-pdk"
+	"github.com/stretchr/testify/assert"
+)
+
+type Config struct{}
+
+// Plugin used for tests
+func (conf *Config) Access(kong *pdk.PDK) {
+	path, err := kong.Request.GetPath()
+	if err != nil {
+		kong.Response.Exit(http.StatusInternalServerError, err.Error(), nil)
+		return
+	}
+
+	switch path {
+	case "/method":
+		method, err := kong.Request.GetMethod()
+		if err != nil {
+			kong.Response.Exit(http.StatusInternalServerError, err.Error(), nil)
+			return
+		}
+
+		switch method {
+		case "GET":
+			kong.Response.Exit(http.StatusOK, "get", nil)
+		case "POST":
+			kong.Response.Exit(http.StatusOK, "post", nil)
+		default:
+			kong.Response.ExitStatus(http.StatusNotImplemented)
+		}
+	default:
+		kong.Response.ExitStatus(http.StatusNotImplemented)
+	}
+}
+
+func TestAllowGET(t *testing.T) {
+	env, err := New(t, Request{
+		Method: "GET",
+		Url:    "http://localhost/method",
+	})
+	assert.NoError(t, err)
+
+	env.DoHttps(&Config{})
+	assert.Equal(t, 200, env.ClientRes.Status)
+	assert.Equal(t, "get", env.ClientRes.Body)
+}
+
+func TestAllowPOST(t *testing.T) {
+	env, err := New(t, Request{
+		Method: "POST",
+		Url:    "http://localhost/method",
+	})
+	assert.NoError(t, err)
+
+	env.DoHttps(&Config{})
+	assert.Equal(t, 200, env.ClientRes.Status)
+	assert.Equal(t, "post", env.ClientRes.Body)
+}
+
+func TestExitStatus(t *testing.T) {
+	env, err := New(t, Request{
+		Method: "POST",
+		Url:    "http://localhost/notimplimented",
+		Body:   "Should not copy",
+	})
+	assert.NoError(t, err)
+
+	env.DoHttps(&Config{})
+	assert.Equal(t, http.StatusNotImplemented, env.ClientRes.Status)
+	assert.Equal(t, "", env.ClientRes.Body)
+}