Merge pull request #3 from Faultygaming/OutlawRogue

OutlawRogue
Krealle · Nov 17, 2024 · a02790a · a02790a
2 parents 1723e9d + 1b4d943
commit a02790a
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 89 deletions.
diff --git a/src/analysis/retail/rogue/outlaw/CONFIG.tsx b/src/analysis/retail/rogue/outlaw/CONFIG.tsx
@@ -3,7 +3,7 @@ import SPECS from 'game/SPECS';
 import { AlertWarning } from 'interface';
 import { Anty } from 'CONTRIBUTORS';
 
-// import CHANGELOG from './CHANGELOG';
+import CHANGELOG from './CHANGELOG';
 import Config, { SupportLevel } from 'parser/Config';
 
 const config: Config = {
@@ -32,17 +32,17 @@ const config: Config = {
   ),
   // A recent example report to see interesting parts of the spec. Will be shown on the homepage.
   exampleReport:
-    '/report/t27zV8NLgPvJq3Kk/17-Mythic+Terros+-+Kill+(5:47)/Zirëael/standard/overview',
+    '/report/VD9BxCQ8mwpaycMP/4-Normal+Queen+Ansurek+-+Kill+(6:16)/Shadowbladëz/standard/overview',
   // Don't change anything below this line;
   // The current spec identifier. This is the only place (in code) that specifies which spec this parser is about.
   spec: SPECS.OUTLAW_ROGUE,
   // The contents of your changelog.
-  // changelog: CHANGELOG,
+  changelog: CHANGELOG,
   // The CombatLogParser class for your spec.
-  // parser: () =>
-  //   import('./CombatLogParser' /* webpackChunkName: "OutlawRogue" */).then(
-  //     (exports) => exports.default,
-  //   ),
+  parser: () =>
+     import('./CombatLogParser' /* webpackChunkName: "OutlawRogue" */).then(
+       (exports) => exports.default,
+     ),
   // The path to the current directory (relative form project root). This is used for generating a GitHub link directly to your spec's code.
   path: import.meta.url,
 };

diff --git a/src/analysis/retail/rogue/outlaw/CombatLogParser.ts b/src/analysis/retail/rogue/outlaw/CombatLogParser.ts
@@ -4,11 +4,8 @@ import {
   EnergyDetails,
   EnergyTracker,
   Flagellation,
-  SerratedBoneSpike,
   SpellEnergyCost,
   InstantPoison,
-  Sepsis,
-  StealthAbilityFollowingSepsis,
   ThistleTeaCastLinkNormalizer,
 } from 'analysis/retail/rogue/shared';
 import CoreCombatLogParser from 'parser/core/CombatLogParser';
@@ -99,11 +96,8 @@ class CombatLogParser extends CoreCombatLogParser {
     sliceAndDiceUptime: SliceAndDiceUptime,
     //Talents
     bladeRush: BladeRush,
-    serratedBoneSpike: SerratedBoneSpike,
     echoingReprimand: EchoingReprimand,
     flagellation: Flagellation,
-    sepsis: Sepsis,
-    stealthAbilityFollowingSepsis: StealthAbilityFollowingSepsis,
 
     // Outlaw's throughput benefit isn't as big as for other classes since we don't have a lot of free gcds to use
     arcaneTorrent: [

diff --git a/src/analysis/retail/rogue/outlaw/modules/Abilities.tsx b/src/analysis/retail/rogue/outlaw/modules/Abilities.tsx
@@ -105,12 +105,6 @@ class Abilities extends CoreAbilities {
           extraSuggestion: `Using Adrenaline Rush on cooldown is very important and should only be delayed when you know you won't be able to attack for the majority of it's duration.`,
         },
       },
-      {
-        spell: TALENTS.SHADOW_DANCE_TALENT.id,
-        category: SPELL_CATEGORY.COOLDOWNS,
-        cooldown: 60,
-        enabled: combatant.hasTalent(TALENTS.SHADOW_DANCE_TALENT),
-      },
       {
         spell: TALENTS.THISTLE_TEA_TALENT.id,
         category: SPELL_CATEGORY.COOLDOWNS,
@@ -307,45 +301,6 @@ class Abilities extends CoreAbilities {
         spell: SPELLS.SAP.id,
         category: SPELL_CATEGORY.UTILITY,
       },
-      // Covenant Abilities
-      {
-        spell: TALENTS.SERRATED_BONE_SPIKE_TALENT.id,
-        category: SPELL_CATEGORY.ROTATIONAL,
-        enabled: false,
-        charges: 3,
-        cooldown: 30,
-        gcd: {
-          static: standardGcd,
-        },
-      },
-      {
-        spell: TALENTS.SEPSIS_TALENT.id,
-        category: SPELL_CATEGORY.ROTATIONAL,
-        enabled: false,
-        cooldown: 90,
-        gcd: {
-          static: standardGcd,
-        },
-        castEfficiency: {
-          suggestion: true,
-        },
-      },
-      {
-        spell: TALENTS.ECHOING_REPRIMAND_TALENT.id,
-        category: SPELL_CATEGORY.ROTATIONAL,
-        enabled: false,
-        gcd: {
-          static: standardGcd,
-        },
-      },
-      {
-        spell: TALENTS.FLAGELLATION_TALENT.id,
-        category: SPELL_CATEGORY.ROTATIONAL,
-        enabled: false,
-        gcd: {
-          static: standardGcd,
-        },
-      },
     ];
   }
 }

diff --git a/src/analysis/retail/rogue/outlaw/modules/apl/AplCheck.tsx b/src/analysis/retail/rogue/outlaw/modules/apl/AplCheck.tsx
@@ -67,10 +67,6 @@ const rtbCondition = () => {
           and(buffMissing(SPELLS.SKULL_AND_CROSSBONES), buffMissing(SPELLS.BROADSIDE)),
         ),
         // allow not rerolling during dance window
-        or(
-          buffMissing(SPELLS.SHADOW_DANCE_BUFF),
-          optionalRule(buffPresent(SPELLS.SHADOW_DANCE_BUFF)),
-        ),
         // allow not rerolling during subterfuge window
         or(buffMissing(SPELLS.SUBTERFUGE_BUFF), optionalRule(buffPresent(SPELLS.SUBTERFUGE_BUFF))),
         // same for vanish buff
@@ -89,7 +85,6 @@ const rtbCondition = () => {
 const notInStealthCondition = () => {
   return describe(
     and(
-      buffMissing(SPELLS.SHADOW_DANCE_BUFF),
       buffMissing(SPELLS.SUBTERFUGE_BUFF),
       buffMissing(SPELLS.STEALTH_BUFF),
       buffMissing(SPELLS.VANISH_BUFF),
@@ -149,25 +144,6 @@ const COMMON_COOLDOWN: Rule[] = [
       ),
     ),
   },
-  {
-    spell: TALENTS.SHADOW_DANCE_TALENT,
-    condition: describe(
-      and(
-        buffMissing(SPELLS.AUDACITY_TALENT_BUFF),
-        buffMissing(SPELLS.OPPORTUNITY),
-        //This is a given no point displaying it
-        notInStealthCondition(),
-        //We want to allow the user to press dance at max cp, but that is not a requirement
-        or(not(hasFinisherCondition()), optionalRule(hasFinisherCondition())),
-      ),
-      (tense) => (
-        <>
-          <SpellLink spell={SPELLS.AUDACITY_TALENT_BUFF} /> and{' '}
-          <SpellLink spell={SPELLS.OPPORTUNITY} /> {tenseAlt(tense, 'are', 'were')} missing
-        </>
-      ),
-    ),
-  },
 ];
 
 const COMMON_FINISHER: Rule[] = [
@@ -196,10 +172,6 @@ const COMMON_FINISHER: Rule[] = [
         and(
           hasFinisherCondition(),
           //We allow the user to not press BtE when in dance
-          or(
-            buffMissing(SPELLS.SHADOW_DANCE_BUFF),
-            optionalRule(buffPresent(SPELLS.SHADOW_DANCE_BUFF)),
-          ),
         ),
         (tense) => <>the finisher condition {tenseAlt(tense, 'is', 'was')} met</>,
       ),
@@ -271,7 +243,6 @@ const COMMON_BUILDER: Rule[] = [
       buffPresent(SPELLS.AUDACITY_TALENT_BUFF, 100),
       describe(
         or(
-          buffPresent(SPELLS.SHADOW_DANCE_BUFF),
           buffPresent(SPELLS.SUBTERFUGE_BUFF),
           buffPresent(SPELLS.STEALTH_BUFF),
           buffPresent(SPELLS.VANISH_BUFF),

diff --git a/tsconfig.json b/tsconfig.json
@@ -42,7 +42,6 @@
     "src/analysis/retail/deathknight/unholy",
     "src/analysis/retail/priest/discipline",
     "src/analysis/retail/rogue/subtlety",
-    "src/analysis/retail/rogue/outlaw",
     "src/analysis/retail/rogue/shared",
     "src/analysis/retail/warlock/demonology",
     "src/analysis/retail/warlock/destruction",
@@ -54,7 +53,6 @@
     "./src/analysis/retail/mage/frost/CONFIG.tsx",
     "./src/analysis/retail/priest/discipline/CONFIG.tsx",
     "./src/analysis/retail/rogue/subtlety/CONFIG.tsx",
-    "./src/analysis/retail/rogue/outlaw/CONFIG.tsx",
     "./src/analysis/retail/warlock/affliction/CONFIG.tsx",
     "./src/analysis/retail/warlock/demonology/CONFIG.tsx",
     "./src/analysis/retail/warlock/destruction/CONFIG.tsx",