Essence Burst abstraction #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule can function properly
Krealle
added a commit
that referenced
this pull request
Apr 25, 2024
…WoWAnalyzer#6719) * update pupil related links for aug * add EB_FROM_ARCANE_VIGOR castlink for deva * rework of LeapingFlamesNormalizer * Reworked LeapingFlames * some minor changes * Essence Burst abstraction (#3) * Abstract Essence Burst links to new shared file * Fix missing isActive for PUPIL_OF_ALEXSTRASZA_TALENT cast link * Move Preservations EBRefreshNormalizer to shared normalizers * Update import for Preservation * Update eventGeneratedEB call for Anachronism * Update function calls for LeapingFlames * add EssenceBurstCastLinkNormalizer to preservation so LeapingFlames module can function properly * Update Deva EssenceBurstOrder normalizer to properly catch all leaping EBs * remove EB_FROM_ARCANE_VIGOR link from deva specific normalizer * rename EBRefreshNormalizer to EssenceBurstRefreshNormalizer * Add EB_FROM links to Azure Strike and Emerald Trance * Add the new castlinks to filter and update variable naming * add some more documentation * emerald trance produces first EB after 5seconds * Emerald trance should take priority over Azure Strike * jsdoc update * change logic for leaping hits and pupil links so we can simplify dependencies * simplify hasNoGenerationLink to make it more streamlined to add future sources * refactor EssenceBurstRefreshNormalizer so it removes the proper abilities * update EssenceBurstNormalizer dependencies * add normalizer dependency for preservation castlinknormalizer * prettier must be satisfied! * only check for leaping links if leaping is talented * implement LeapingFlamesBuffNormalizer * Implement maxLinks check for LEAPING_FLAMES_HITS cast link check * add LeapingFlamesBuffNormalizer to combatlogparsers * add EssenceBurstRefreshNormalizer dep to EssenceBurstCastLinkNormalizer * remove LeapingFlamesBuffNormalizer in favor of a cast link * yeet the logs and write some documentation * yeet some more stuff * add a lil more info * yeet this export * readability changes * another readability change * make this variable more descriptive * changelog * fix options imports to match PutPuts cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So in essence this just makes the
Essence Burstnormalization / cast link shared.Reasoning behind it is essentially that to get proper deterministic results for the
Leaping Flamesmodule, we need to narrow down the source of anEssence Burst. Currently that is all done on a spec-by-spec basis, which neccesitates a certain hierarchy of when the different normalizers run. We need the links from the Devastation and Augmentation'sCastLinkNormalizer, which would be a relatively easy to do, but Preservation has links being made that rely on the links made inLeapingFlamesNormalizer- which means you start doing stuff like thisNot ideal!
So a better solution is simply to deal with all the important
Essence Burstnormalization in a shared normalizer, which we can then make ourLeapingFlamesNormalizerdepend on.All the
EssenceBurstCastLinkNormalizerdoes is create links between generation sources and the generated/wastedEssence Burst. Along with providing some helper functions to help make analysis a bit easier.The
EBRefreshNormalizerhas also been moved from Preservation to shared.