-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2][WIP] Move pro items outside core (aka open-core split) #4113
Closed
+251
−7,885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
TODO on Github:
TODO on our website:
|
53 tasks
tabacitu
changed the title
[4.2] Move pro items outside core (aka open-core split)
[4.2][WIP] Move pro items outside core (aka open-core split)
Jan 24, 2022
The inspection completed: 554 Issues, 75 Patches |
…o and BelongsToMany relationships
[ci skip] [skip ci]
…ove-pro-items-outside-core # Conflicts: # src/resources/views/crud/fields/inc/repeatable_row.blade.php # src/resources/views/crud/fields/relationship/entries.blade.php
it no longer makes sense after the open-core split
[ci skip] [skip ci]
# Conflicts: # src/resources/views/crud/columns/table.blade.php # src/resources/views/crud/fields/inc/repeatable_row.blade.php # src/resources/views/crud/fields/relationship.blade.php # src/resources/views/crud/fields/relationship/entries.blade.php # src/resources/views/crud/fields/relationship/select.blade.php # src/resources/views/crud/fields/repeatable.blade.php # src/resources/views/crud/fields/select2_grouped.blade.php # src/resources/views/crud/fields/select2_multiple.blade.php # src/resources/views/crud/fields/select_grouped.blade.php # src/resources/views/crud/filters/date_range.blade.php # src/resources/views/crud/filters/range.blade.php # src/resources/views/crud/filters/select2.blade.php # src/resources/views/crud/filters/select2_ajax.blade.php # src/resources/views/crud/filters/select2_multiple.blade.php # src/resources/views/crud/filters/text.blade.php
Merged
It is DONE. I've merged both this and 4.2 into a branch I've called I'm going to close both this and the 4.2 branch, so that from now on we work with the v5 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
Fixes #4098
BEFORE - What was wrong? What was happening before this PR?
All of our features were public-source, but under a restricted proprietary license. This was bad in two ways:
AFTER - What is happening after this PR?
We've slit the features into two projects:
HOW
How did you achieve that, in technical terms?
Created a new repo and moved what was needed there.
Is it a breaking change or non-breaking change?
VERY breaking.
How can we test the before & after?
If you install 4.2, you should NOT get all the features. Only after you add this to your
composer.json
:and run
composer require backpack/pro
should you be able to do all you could previously do in Backpack.