Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(431-2): active network icon has too much margin and adding optional prop #12405

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Nov 22, 2024

Description

The active network icon in the header has too much margin and is misaligned with the network title.

I have also added an optional prop of networkName that allows developers to pass in the network name of their choice. This is in preparation of multichain support, currently we are showing the selected network name, in multichain we want to be able to pass in a network name and not the selected chain.

Related issues

Fixes:

Manual testing steps

  1. Goto asset details, swaps, or buy. Basically any screen that has the header with network name

Screenshots/Recordings

(green icon at the very top)

Before After
asset_details_ios_before asset_details_ios_after

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested review from a team as code owners November 22, 2024 23:58
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward changed the title fix: active network icon has too much margin fix(431-2): active network icon has too much margin Nov 22, 2024
@vinnyhoward vinnyhoward added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1fdf1bf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5fad9f4e-6f24-461b-b5a3-7dc5b3b53bee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward changed the title fix(431-2): active network icon has too much margin fix(431-2): active network icon has too much margin and adding optional prop Nov 23, 2024
Copy link

sonarcloud bot commented Nov 23, 2024

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L enabled auto-merge November 26, 2024 21:25
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vinnyhoward vinnyhoward mentioned this pull request Nov 28, 2024
7 tasks
@Cal-L Cal-L added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit b221d14 Dec 2, 2024
52 of 54 checks passed
@Cal-L Cal-L deleted the fix-header-active-network-icon branch December 2, 2024 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants