-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(431-2): active network icon has too much margin and adding optional prop #12405
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 1fdf1bf Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
The active network icon in the header has too much margin and is misaligned with the network title.
I have also added an optional prop of
networkName
that allows developers to pass in the network name of their choice. This is in preparation of multichain support, currently we are showing the selected network name, in multichain we want to be able to pass in a network name and not the selected chain.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
(green icon at the very top)
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist