Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR#94 #126

Merged
merged 9 commits into from
Mar 15, 2024
Merged

UFS-dev PR#94 #126

merged 9 commits into from
Mar 15, 2024

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Feb 6, 2024

Identical to ufs-community#1845 (BL change and INPUT change - see comment below)

Also contains:
ufs-community#2064 (no BL change)
ufs-community#2085 (no BL change; rt.sh change)
ufs-community#2059 (no BL change)
ufs-community#2090 (BL change - cpld_control_gfsv17_iau)

SamuelTrahanNOAA and others added 7 commits January 17, 2024 15:01
…FS on WCOSS2 (ufs-community#2064)

* Eliminate an out-of-bounds write in FV3 dynamical core hail diagnostic code.

* FV3 component GFDL_atmos_cubed_sphere submodule:

* The module_diag_hailcast.F90 has a KBAS index which can have the value of 1. When it has that value, a later line writes to address 0 of a 1-based array. This caused the RRFS ensemble to crash on WCOSS2.

* fix out-of-bounds write in module_diag_hailcast

* remove unused variable DO_MYJPBL from default_vars.sh (it has a typo in its value)

* only correct RWA_new where RWA_adiabat(k).ge.1.E-12

* module_diag_hailcast.F90: update comments; changes from @adams-selin
…ommunity#2086); Allow MOM6 to write non-interval restarts (was ufs-community#2099) (ufs-community#2085)

fix potential divide by zero in WW3 appendtail routine
add timers to WW3 mesh cap
add non-interval restart capability to MOM6
…rent (ufs-community#2059)

use single MPI_Bcast (via mpp_broadcast()) instead of multiple point-to-point messages (via mpp_send/mpp_recv)
address issue maxing out the SlingShot-10 link on the first node resulting in a .15s hit every fifth time step
…ufs-community#2090)

Update diag_able for global coupled iau test cpld_control_gfsv17_iau for mom6 history output
…nity#1845)

Enable fully could atmosphere-land configuration
Supplementary physics updates (MYNN, GF, RUC_LSM, smoke and dust) for RRFS code freeze
@grantfirl
Copy link
Collaborator Author

1845 failed RTs:
control_p8_mynn_intel regional_control_intel regional_decomp_intel regional_2threads_intel regional_noquilt_intel regional_netcdf_parallel_intel regional_2dwrtdecomp_intel regional_wofs_intel rap_control_intel regional_spp_sppt_shum_skeb_intel rap_decomp_intel rap_2threads_intel rap_sfcdiff_intel rap_sfcdiff_decomp_intel hrrr_control_intel hrrr_control_decomp_intel hrrr_control_2threads_intel rrfs_v1beta_intel rrfs_v1nssl_intel rrfs_v1nssl_nohailnoccn_intel regional_control_faster_intel regional_debug_intel rap_control_debug_intel hrrr_control_debug_intel hrrr_gf_debug_intel hrrr_c3_debug_intel rap_unified_drag_suite_debug_intel rap_diag_debug_intel rap_cires_ugwp_debug_intel rap_unified_ugwp_debug_intel rap_lndp_debug_intel rap_progcld_thompson_debug_intel rap_noah_debug_intel rap_sfcdiff_debug_intel rap_noah_sfcdiff_cires_ugwp_debug_intel rrfs_v1beta_debug_intel rap_clm_lake_debug_intel rap_flake_debug_intel gnv1_c96_no_nest_debug_intel regional_spp_sppt_shum_skeb_dyn32_phy32_intel rap_control_dyn32_phy32_intel hrrr_control_dyn32_phy32_intel rap_2threads_dyn32_phy32_intel hrrr_control_2threads_dyn32_phy32_intel hrrr_control_decomp_dyn32_phy32_intel conus13km_control_intel rap_control_dyn64_phy32_intel rap_control_debug_dyn32_phy32_intel hrrr_control_debug_dyn32_phy32_intel conus13km_debug_intel conus13km_debug_qr_intel conus13km_debug_2threads_intel conus13km_radar_tten_debug_intel rap_control_dyn64_phy32_debug_intel gnv1_nested_intel rap_control_gnu rap_decomp_gnu rap_2threads_gnu rap_sfcdiff_gnu rap_sfcdiff_decomp_gnu hrrr_control_gnu hrrr_control_noqr_gnu hrrr_control_2threads_gnu hrrr_control_decomp_gnu rrfs_v1beta_gnu regional_debug_gnu rap_control_debug_gnu hrrr_control_debug_gnu hrrr_gf_debug_gnu hrrr_c3_debug_gnu rap_diag_debug_gnu rap_noah_sfcdiff_cires_ugwp_debug_gnu rap_progcld_thompson_debug_gnu rrfs_v1beta_debug_gnu rap_flake_debug_gnu rap_clm_lake_debug_gnu gnv1_c96_no_nest_debug_gnu rap_control_dyn32_phy32_gnu hrrr_control_dyn32_phy32_gnu rap_2threads_dyn32_phy32_gnu hrrr_control_2threads_dyn32_phy32_gnu hrrr_control_decomp_dyn32_phy32_gnu conus13km_control_gnu rap_control_dyn64_phy32_gnu rap_control_debug_dyn32_phy32_gnu hrrr_control_debug_dyn32_phy32_gnu conus13km_debug_gnu conus13km_debug_qr_gnu conus13km_debug_2threads_gnu conus13km_radar_tten_debug_gnu rap_control_dyn64_phy32_debug_gnu

New input:
input-data-20221101/NOAHMP_IC/
input-data-20221101/DATM_ERA5_input_data_v2/

@grantfirl grantfirl marked this pull request as ready for review March 14, 2024 22:12
@grantfirl grantfirl requested a review from mkavulich March 15, 2024 14:35
Copy link
Collaborator

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once submodule is updated

@grantfirl grantfirl merged commit 4130e18 into NCAR:main Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants