-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bucket change during integration #775
Conversation
I think one item for RRFS got lost along the way - the need for tracking multiple bucket lengths at the same time (namely 15 minute and 1 hour). But we've recently decided to avoid generating most "bucket" type fields from the RRFS 15 minute output, and just use an external code to generate 15 minute QPF buckets from the running QPF total. Sorry for the confusion. |
@MatthewPyle-NOAA Thanks for clarification. Currently model does not support multiple buckets at the same time. In this branch, model only supports a single bucket, but the bucket length could change. I tested the branch with non-integer bucket length (0.25 hour), this history has correct bucket length, but UPP does not support non-integer bucket. Here is the output from a test run: history file:
The post grib file:
|
Thanks for your work on getting sub-hourly buckets working (at least in the model). I'm guessing we'll use this functionality in some fashion with RRFS for our 15 minute output. |
@junwang-noaa @MatthewPyle-NOAA Should this change go to develop or RRFSv1 branch or maybe both? |
@DusanJovic-NOAA We won't be utilizing it in RRFSv1, so just develop is fine. |
This was replaced by #835. Closing. |
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
RRFS requested to allow bucket change during integration. This is initial code updates for that capability.
At this time, the bucket (fhzero) is updated the forecast side, we need to update attribute at forecast time to pass the change to write grid component.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
test with regional_control test. The code is backward compatible, there is no impact on current tests.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs