Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket change during integration #775

Closed
wants to merge 16 commits into from

Conversation

junwang-noaa
Copy link
Collaborator

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?

RRFS requested to allow bucket change during integration. This is initial code updates for that capability.

At this time, the bucket (fhzero) is updated the forecast side, we need to update attribute at forecast time to pass the change to write grid component.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

test with regional_control test. The code is backward compatible, there is no impact on current tests.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@DusanJovic-NOAA DusanJovic-NOAA changed the title bucket change during integration Bucket change during integration Jan 26, 2024
@MatthewPyle-NOAA
Copy link
Collaborator

I think one item for RRFS got lost along the way - the need for tracking multiple bucket lengths at the same time (namely 15 minute and 1 hour). But we've recently decided to avoid generating most "bucket" type fields from the RRFS 15 minute output, and just use an external code to generate 15 minute QPF buckets from the running QPF total. Sorry for the confusion.

@junwang-noaa
Copy link
Collaborator Author

@MatthewPyle-NOAA Thanks for clarification. Currently model does not support multiple buckets at the same time. In this branch, model only supports a single bucket, but the bucket length could change. I tested the branch with non-integer bucket length (0.25 hour), this history has correct bucket length, but UPP does not support non-integer bucket.

Here is the output from a test run:

history file:

// global attributes:
                :cen_lat = 38.f ;
                :cen_lon = -120.f ;
                :dtp = 36.f ;
                :dx = 3000.f ;
                :dy = 3000.f ;
                :fhzero = 0.25f ;
                :grid = "lambert_conformal" ;
                :grid_id = 1LL ;

The post grib file:

851:33388831:vt=2022082403:surface:3-3 hour acc fcst:APCP Total Precipitation [kg/m^2]:
    ndata=61440:undef=511:mean=0:min=0:max=0
    grid_template=30:winds(N/S):
        Lambert Conformal: (320 x 192) input WE:SN output WE:SN res 0
        Lat1 35.299999 Lon1 234.750000 LoV 240.000000
        LatD 38.000000 Latin1 38.000000 Latin2 38.000000
        LatSP 0.000000 LonSP 0.000000
        North Pole (320 x 192) Dx 3000.000000 m Dy 3000.000000 m mode 0

@MatthewPyle-NOAA
Copy link
Collaborator

Thanks for your work on getting sub-hourly buckets working (at least in the model). I'm guessing we'll use this functionality in some fashion with RRFS for our 15 minute output.

atmos_model.F90 Outdated Show resolved Hide resolved
io/post_fv3.F90 Outdated Show resolved Hide resolved
io/module_wrt_grid_comp.F90 Outdated Show resolved Hide resolved
@DusanJovic-NOAA
Copy link
Collaborator

@junwang-noaa @MatthewPyle-NOAA Should this change go to develop or RRFSv1 branch or maybe both?

@MatthewPyle-NOAA
Copy link
Collaborator

@DusanJovic-NOAA We won't be utilizing it in RRFSv1, so just develop is fine.

@DusanJovic-NOAA
Copy link
Collaborator

This was replaced by #835. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to handle accumulations and max/min computations over multiple time windows
5 participants