Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zacas): fix check exception for amocas. #693

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(zacas): fix check exception for amocas. #693

merged 1 commit into from
Dec 5, 2024

Conversation

NewPaulWalker
Copy link
Contributor

No description provided.

@NewPaulWalker
fix(zacas): fix check exception for amocas.
7c2ec85 
* Check illegal instruction before trigger check and misalign check

* Check misalign for 128-bit amocas.q

* Check store feasibility before actually load or store
@NewPaulWalker NewPaulWalker changed the title fix(zacas): check misalign for 16 bytes amocas. fix(zacas): fix check exception for amocas. Dec 3, 2024
huxuan0307
huxuan0307 requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@huxuan0307 huxuan0307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pmp_check_permission argument needs modification

@huxuan0307
Copy link
Contributor

Wrong pmp_check_permission argument needs modification

My misunderstanding.

@huxuan0307 huxuan0307 merged commit bc0d3d1 into OpenXiangShan:master Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huxuan0307 huxuan0307 huxuan0307 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NewPaulWalker @huxuan0307