forked from riscv-software-src/riscv-isa-sim
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diff memcpy COW optimization #5
Open
tastynoob
wants to merge
73
commits into
difftest
Choose a base branch
from
cow-optim
base: difftest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to catiss repo.
Migrate the original code from OpenXiangShan and re-write it with C++ style classes for the upstream riscv-isa-sim.
Rocket-chip restricts the values of MSTATUS.FS.
rocket-chip sets the xtval to instruction values when exceptions. However, XiangShan and NutShell simply clear it, which is also compatible with the RISC-V ISA.
It seems sim_t::addr_to_mem allocates the memory of only PGSIZE bytes at every time. Therefore, we need to separate memcpy operations.
Different DUTs may have different physical address bits.
Both rocket-chip and NutShell do not implement ASIDs.
We add diff_trace_t class to record Spike's actions including * instructions executed * store requests * load requests * page-table walker requests With the above information, we add support for the store commit diff.
Rocket-chip sets the value to zero.
Load operations may cause exceptions. The is_amo flag must be set just before the store is processed.
This commit adds the Sdtrig ISA string for the RISC-V Triggers extension with permission check for the related CSRs.
This CSR only exists if Sdtrig is enabled.
* misa * satp * mimpid * marchid
Practical hardware designs would have reservation sets of 64B. However, Spike seems to have only byte-level reservation sets. I'm not sure whether it would violate the ISA.
If virtual memory has not been enabled, the CPU is not expected to cache any PTEs and should not behave differently with Spike.
There was a macro MAX_INSN_LENGTH, but it seems not to be used anywhere. We use it to decode the maximum insn_length.
When skipping instructions, minstret should be incremented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.