Skip to content

Commit

Permalink
Update to PSPDFKit for Android version 6.6.0 (#388)
Browse files Browse the repository at this point in the history
* Bump PSPDFKit for Android from 6.5.3 to 6.6.0
* Bump plugin version to 1.30.8
* Updates example commit for doing a version bump
  • Loading branch information
amit-nayar authored Feb 11, 2021
1 parent 33e2560 commit 265ded9
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@

# Acceptance Criteria

- [ ] When approved, right before merging, rebase with master and increment the package version in `package.json`, `package-lock.json`, `samples/Catalog/package.json`, and `samples/NativeCatalog/package.json` (see example commit: https://github.com/PSPDFKit/react-native/pull/202/commits/1bf805feef2ac268743e4905d94d6d8c8f16ec59).
- [ ] When approved, right before merging, rebase with master and increment the package version in `package.json`, `package-lock.json`, `samples/Catalog/package.json`, and `samples/NativeCatalog/package.json` (see example commit: https://github.com/PSPDFKit/react-native/pull/389/commits/ae027329b5380906fa778354945178c7e92730a4).
- [ ] Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ target 'YourApp' do
end
+ pod 'react-native-pspdfkit', :path => '../node_modules/react-native-pspdfkit'
+ pod 'PSPDFKit', podspec: 'https://customers.pspdfkit.com/pspdfkit-ios/latest.podspec'

# Enables Flipper.
#
# Note that if you have use_frameworks! enabled, Flipper will not work and
Expand Down Expand Up @@ -371,7 +371,7 @@ For a runnable example, please take a look at the [AnnotationProcessing example
- Android Build Tools 23.0.1 (React Native)
- Android Build Tools 28.0.3 (PSPDFKit module)
- Android Gradle plugin >= 3.4.1
- PSPDFKit >= 6.5.3
- PSPDFKit >= 6.6.0
- react-native >= 0.63.2

#### Getting Started
Expand Down Expand Up @@ -608,12 +608,12 @@ The PSPDFKit React Native Android Wrapper allows you to specify a custom groupin
#### Update
Upgrading yarn's lock file is required in order to update react-native-pspdfkit module in a project that has been already setup following the steps in [Getting Started](#getting-started-1) section.
Upgrading yarn's lock file is required in order to update react-native-pspdfkit module in a project that has been already setup following the steps in [Getting Started](#getting-started-1) section.
From root project folder (e.g.`YourApp` for upgrading example project) launch `yarn upgrade`.

##### Migrate from PSPDFKit version 2.9.x to 3.0.0

After launching `yarn upgrade`, apply [step 7](#step-7), [step 10](#step-10) and [step 12](#step-12) from [Getting Started](#getting-started-1) section.
After launching `yarn upgrade`, apply [step 7](#step-7), [step 10](#step-10) and [step 12](#step-12) from [Getting Started](#getting-started-1) section.
Enable MultiDex in `YourApp/android/app/build.gradle` (note **one** place to edit):

```diff
Expand All @@ -636,7 +636,7 @@ defaultConfig {
...
```
Remove `pspdfkit-lib` folder in `YourApp/android/`.
Remove `pspdfkit-lib` folder in `YourApp/android/`.
In `YourApp/android/settings.gradle` remove the old reference to `pspdfkit-lib` (note **one** place to edit):
```diff
Expand All @@ -647,7 +647,7 @@ Remove `pspdfkit-lib` folder in `YourApp/android/`.
##### Migrate from PSPDFKit version 3.3.3 to 4.0.x
After launching `yarn upgrade`, apply [step 6](#step-6), [step 8](#step-8) and [step 10](#step-10) from [Getting Started](#getting-started-1) section.
After launching `yarn upgrade`, apply [step 6](#step-6), [step 8](#step-8) and [step 10](#step-10) from [Getting Started](#getting-started-1) section.
Enable MultiDex in `YourApp/android/app/build.gradle` (note **four** place to edit):
```diff
Expand Down Expand Up @@ -697,7 +697,7 @@ Windows UWP is not currently supported on `master`, please follow the integratio
## License
This project can be used for evaluation or if you have a valid PSPDFKit license.
This project can be used for evaluation or if you have a valid PSPDFKit license.
All items and source code Copyright © 2010-2021 PSPDFKit GmbH.
See LICENSE for details.
Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* Contains gradle configuration constants
*/
ext {
PSPDFKIT_VERSION = '6.5.3'
PSPDFKIT_VERSION = '6.6.0'
}

buildscript {
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-pspdfkit",
"version": "1.30.7",
"version": "1.30.8",
"description": "A React Native module for the PSPDFKit library.",
"keywords": [
"react native",
Expand Down
2 changes: 1 addition & 1 deletion samples/Catalog/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Catalog",
"version": "1.30.7",
"version": "1.30.8",
"private": true,
"scripts": {
"start": "react-native start",
Expand Down
2 changes: 1 addition & 1 deletion samples/NativeCatalog/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "NativeCatalog",
"version": "1.30.7",
"version": "1.30.8",
"private": true,
"scripts": {
"android": "react-native run-android",
Expand Down

0 comments on commit 265ded9

Please sign in to comment.