Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module/asg): Introduce Instance Refresh for ASG module #3

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

sebastianczech
Copy link
Contributor

Description

PR introduces new feature for ASG module - instance refresh, which can be customized by allowing to change every possible attribute for instance refresh block.

Motivation and Context

#416

How Has This Been Tested?

Code was tested by extending example isolated_design_autoscale and deploying it in the lab.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech requested a review from a team as a code owner January 4, 2024 19:19
@sebastianczech
Copy link
Contributor Author

/help

@migara
Copy link
Member

migara commented Jan 8, 2024

/help

ChatOPS built in help:

Currently supported commands include:

  • /sca - run all SCA tests via pre-commit
  • /validate - run terraform validate
  • /plan - plan the infrastructure (only examples)
  • /apply - deploy the infrastructure and destroy afterwards (only examples)
  • /idempotence - test idempotence: deploy, plan and destroy afterwards (only examples).

The 1st command does not take arguments, the remaining take two:

  • paths - a space delimitied list of module paths
  • tf_version - (optional, defaults to the latest available) a space delimited list of Terraform versions to test the infrastrucure against.

Examples:

# run idempotence tests on listed modules with Terraform versions: 1.2 (latest patch available), 1.4 (latest patch available), 1.5.4.
/idempotence paths="examples/combined_design examples/panorama_standalone" tf_version="1.2 1.4 1.5.4"
# run validation tests with the latest available Terraform version on listed modules.
/validate paths="modules/vmseries modules/vpc examples/combined_design"

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 8, 2024

/validate paths="modules/asg"

Testing job ID: 7447837849
Job result: FAILURE

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 8, 2024

/idempotence paths="examples/centralized_design_autoscale examples/combined_design_autoscale examples/isolated_design_autoscale"

Testing job ID: 7448915819
Job result: SUCCESS

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Feb 6, 2024

/idempotence paths="examples/centralized_design_autoscale examples/combined_design_autoscale examples/isolated_design_autoscale" tf_version="1.7"

Testing job ID: 7796107587
Job result: SUCCESS

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Feb 7, 2024

/idempotence paths="examples/centralized_design_autoscale examples/combined_design_autoscale examples/isolated_design_autoscale" tf_version="1.6"

Testing job ID: 7818138941
Job result: SUCCESS

@sebastianczech sebastianczech merged commit 4e40c4e into main Feb 23, 2024
53 checks passed
@sebastianczech sebastianczech deleted the instance-refresh-416 branch February 23, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants