Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module/vpc_route): Refactor vpc_route module - move and simplify locals #71

Closed
wants to merge 53 commits into from
Closed

feat(module/vpc_route): Refactor vpc_route module - move and simplify locals #71

wants to merge 53 commits into from

Conversation

sebastianczech
Copy link
Contributor

Description

Resolves #70

Motivation and Context

#53

How Has This Been Tested?

Code was tested locally and via ChatOps.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech
Remove subnet_set module, extend VPC module to create subnets and rou…
04d8d69 
…te tables, adjust combined_design to new approach
@sebastianczech
Remove commented code
9497473
@sebastianczech
Merge branch 'main' into refactor_vpc_subnet
3def699
@sebastianczech
Extend tests to check if TF version is supported
32ce885
@sebastianczech
Extend tests for module to check if TF version is supported
591ac6d
@sebastianczech
Change order or resources and variables, add URLs to TF registry for …
6354880 
…each resource, simplify locals, remove comments
@sebastianczech
Extend types for security groups and NACL (instead of any)
9e12884
@sebastianczech
Fix problem with VPC routes
05af310
@sebastianczech
Remove try() from module vpc
d203b1d
@sebastianczech
Merge main and change group to subnet_group
ec13310
@sebastianczech
Refactor all variables of vpc module, including variables description
dfbf90c
@sebastianczech
Adjust combined design autoscale example
ac64367
@sebastianczech
Adjust centralized design example
8fe80d7
@sebastianczech
Adjust centralized design autoscale example
b4ed40c
@sebastianczech
Adjust 2 isolated design, Panorama and VM-Series examples
051dc68
@sebastianczech
Fix terratest for VM-Series
03abe62
@sebastianczech
Merge branch 'main' into refactor_vpc_subnet
78000c6
@sebastianczech
Adjust cloud NGGW combined design example
56b5a79
@sebastianczech
Adjust cloud NGGW isolated design example
3886228
@sebastianczech
Fix Terratest
d7f01ec
@sebastianczech
Fix problem with IPv6 for subnets
18b8c5d
@sebastianczech
Fix problem with AZ in Panorama example
24c4e5e
@sebastianczech
Fix problem with NATGW
44a7a67
@sebastianczech
Fix CloudNGFW subnets
6c9c1da
@sebastianczech
Use different CloudWatch log groups for 2 examples with CloudNGFW
0725c9a
@sebastianczech
Use existing CloudWatch log group with the same name for both example…
b3f3501 
…s for CloudNGFW
@sebastianczech
Merge changes from main
c0800b5
@sebastianczech
Do pre-release from rc branch
2ca265a
@sebastianczech
Add validations for VPC variables
3c02bd0
@sebastianczech
Extend optional type after adding validation
a8061a7
@sebastianczech sebastianczech changed the title feat: Refactor vpc_route module - move and simplify locals feat(module/vpc_route): Refactor vpc_route module - move and simplify locals Aug 13, 2024
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 14, 2024 •
edited by github-actions bot
Loading

/plan paths="examples/combined_design"

Testing job ID: 10387041243
Job result: SUCCESS

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 22, 2024 •
edited by github-actions bot
Loading

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10509587002
Job result: FAILURE
Job result: SUCCESS

@sebastianczech sebastianczech marked this pull request as ready for review August 22, 2024 14:06
@sebastianczech sebastianczech requested a review from a team as a code owner August 22, 2024 14:06
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Aug 27, 2024 •
edited by github-actions bot
Loading

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10579918053
Job result: SUCCESS

Base automatically changed from refactor_vpc_subnet to rc August 29, 2024 09:11
@sebastianczech
Copy link
Contributor Author

As I'm not a part of Palo Alto Networks organisation anymore, I cannot merge changes from rc branch into refactor_vpc_route branch to resolve conflicts in this branch. Can somebody from repository owners do it or should I create fork of that repository and open new PR with resolved conflicts ?

@sebastianczech sebastianczech mentioned this pull request Sep 6, 2024
Merged
4 tasks
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Sep 6, 2024 •
edited
Loading

I resolved conflicts by forking repository and opening new PR #79. If you agree on changes in #79, please close this PR without merging.

@michalbil michalbil closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbil michalbil michalbil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor vpc_route module - move and simplify locals
2 participants
@sebastianczech @michalbil