feat(module/vpc_route): Refactor vpc_route module - move and simplify locals

[sebastianczech]

Description

Resolves #70

Motivation and Context

#53

How Has This Been Tested?

Code was tested locally and via ChatOps in #71 (now I don't have an access to ChatOps)

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist

• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes if appropriate.
• All new and existing tests passed.

[michalbil]

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10830850693
Job result: SUCCESS

[michalbil]

/idempotence paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone examples/cloudngfw_combined_design examples/cloudngfw_isolated_design"

Testing job ID: 10831725795
Job result: FAILURE

[sebastianczech]

Thanks @michalbil for executing idempotence tests.
This PR doesn't contain the fix #69, which I prepared at the of August for main branch.
I updated examples/vmseries_standalone about that fix, so that problem:

          	Error:      	Received unexpected error:
          	            	FatalError{Underlying: error while running command: exit status 1; ╷
          	            	│ Error: listing tags for S3 (Simple Storage) Object (arn:aws:s3:::p79-4ee7-176b3c135f5706d5/plugins/): operation error S3: GetObjectTagging, https response error StatusCode: 404, RequestID: TCCHW5A29E2S2EP4, HostID: pkRCTx3QKFrxdER+RBVZt7V82h6Hrmt2OcnlWr0tkmEcPj/TJOWX+Qg8n6cMbyeJMa+LqNd7808=, api error NoSuchKey: The specified key does not exist.
          	            	│ 
          	            	│   with module.bootstrap["vmseries-01"].aws_s3_object.bootstrap_dirs["plugins/"],
          	            	│   on ../../modules/bootstrap/main.tf line 65, in resource "aws_s3_object" "bootstrap_dirs":
          	            	│   65: resource "aws_s3_object" "bootstrap_dirs" {
          	            	│ 
          	            	╵}
          	Test:       	TestIdempotence

should not happen any more.

Are you able to re-execute idempotence tests once again for examples/vmseries_standalone, please ?

[michalbil]

/idempotence paths="examples/vmseries_standalone"

Testing job ID: 10847737046
Job result: SUCCESS

[lstadnik]

Thanks @sebastianczech for your work ! I am very impressed .